1581308 - Remove the non-functional AppMenu button that appears in the Calendar tab with Lightning enabled in SeaMonkey 2.49.5

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[WaltS48 [:walts48]]

Installed SM 2.49.5 64-bit over my 2.49.4 on Ubuntu 18.04.3 LTS.
Started it with my production profile.
Opened the Mail & Newsgroups Window.
Enabled the Calendar tab and noticed the text AppMenu on the right hand side of the Calendar toolbar.
Hovered my mouse pointer over it and a "Display the SeaMonkey Menu" tooltip appeared.
Clicked the AppMenu button and nothing happened.

The button shouldn't be there in SeaMonkey.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1581308-lightning-appmenu.patch

We don't implement the vertical appmenu. It could be fixed in calendar to show the button only in TB but we might want to do it later so I think it is better to just do not display it for now.

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9092847 [details] [diff] [review]
1581308-lightning-appmenu.patch

[Approval Request Comment]
Regression caused by (bug #):  -- 
User impact if declined: useless toolbar item
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 3

[Ian Neal]

Comment on attachment 9092847 [details] [diff] [review]
1581308-lightning-appmenu.patch

[Triage Comment]
LGTM r/a=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c28a66415a5f
Don't show calendar toolbar item for a non existing SeaMonkey vertical menu. r=IanN

Comment 5

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/c63461e34b77cc0a804beb4055070bbd0308f16c

Comment 6

[Frank-Rainer Grahl (:frg)]

Fixed 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/0f67336950240a3884d78a6942e432a24462b26d