Closed Bug 1581317 Opened 2 years ago Closed 2 years ago

"learn more" links don't work for telemetry and crash on Data Choices panel

Categories

(Thunderbird :: Preferences, defect)

defect
Not set
normal

Tracking

(thunderbird_esr6869+ verified, thunderbird71 unaffected)

RESOLVED FIXED
Thunderbird 68.0
Tracking Status
thunderbird_esr68 69+ verified
thunderbird71 --- unaffected

People

(Reporter: wsmwk, Assigned: khushil324)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1563154 +++

68.1.0 "learn more" links don't work for telemetry and crash on Data Choices panel. Nothing in error console

Version: 63 → 68

Khushil has fixed a few of these. Can you take a look, please.

Flags: needinfo?(khushil324)
Assignee: nobody → khushil324
Flags: needinfo?(khushil324)
Attachment #9092925 - Flags: review?(mkmelin+mozilla)
Attachment #9092925 - Flags: feedback?(vseerror)
Status: NEW → ASSIGNED
Comment on attachment 9092925 [details] [diff] [review]
Bug-1581317_learn-more-link_not-wroking.patch

Wayne doesn't build, so he can't give you feedback. Why is gAdvancedPane.openTextLink(event) not needed any more? What happens on click now?
Attachment #9092925 - Flags: feedback?(vseerror)

gAdvancedPane.openTextLink(event) was only used here. And text-link CE does the same thing. I guess when converting links to text-link CE, the original author must have forgotten about these links.

And on the trunk, these links are as text-link CE.

So this is a TB 68 only patch?

Yes, it works fine on Trunk.

Comment on attachment 9092925 [details] [diff] [review]
Bug-1581317_learn-more-link_not-wroking.patch

Let's not forget it then. Approval assuming it passes review. And thanks!!
Attachment #9092925 - Flags: approval-comm-esr68+
Comment on attachment 9092925 [details] [diff] [review]
Bug-1581317_learn-more-link_not-wroking.patch

Review of attachment 9092925 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9092925 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → Thunderbird 68.0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

v.fixed 68.1.1 per walt

You need to log in before you can comment on or make changes to this bug.