Closed
Bug 1581317
Opened 6 years ago
Closed 6 years ago
"learn more" links don't work for telemetry and crash on Data Choices panel
Categories
(Thunderbird :: Preferences, defect)
Tracking
(thunderbird_esr6869+ verified, thunderbird71 unaffected)
RESOLVED
FIXED
Thunderbird 68.0
| Tracking | Status | |
|---|---|---|
| thunderbird_esr68 | 69+ | verified |
| thunderbird71 | --- | unaffected |
People
(Reporter: wsmwk, Assigned: khushil324)
Details
Attachments
(1 file)
|
2.47 KB,
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1563154 +++
68.1.0 "learn more" links don't work for telemetry and crash on Data Choices panel. Nothing in error console
|
Reporter | |
Updated•6 years ago
|
Version: 63 → 68
|
||
Comment 1•6 years ago
|
||
Khushil has fixed a few of these. Can you take a look, please.
Flags: needinfo?(khushil324)
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → khushil324
Flags: needinfo?(khushil324)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #9092925 -
Flags: review?(mkmelin+mozilla)
Attachment #9092925 -
Flags: feedback?(vseerror)
|
|
Assignee | |
Updated•6 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9092925 [details] [diff] [review]
Bug-1581317_learn-more-link_not-wroking.patch
Wayne doesn't build, so he can't give you feedback. Why is gAdvancedPane.openTextLink(event) not needed any more? What happens on click now?
Attachment #9092925 -
Flags: feedback?(vseerror)
|
|
Assignee | |
Comment 4•6 years ago
|
||
gAdvancedPane.openTextLink(event) was only used here. And text-link CE does the same thing. I guess when converting links to text-link CE, the original author must have forgotten about these links.
|
|
Assignee | |
Comment 5•6 years ago
|
||
And on the trunk, these links are as text-link CE.
|
|
||
Comment 6•6 years ago
|
||
So this is a TB 68 only patch?
|
|
Assignee | |
Comment 7•6 years ago
|
||
Yes, it works fine on Trunk.
|
|
||
Comment 8•6 years ago
|
||
Comment on attachment 9092925 [details] [diff] [review]
Bug-1581317_learn-more-link_not-wroking.patch
Let's not forget it then. Approval assuming it passes review. And thanks!!
Attachment #9092925 -
Flags: approval-comm-esr68+
|
||
Updated•6 years ago
|
status-thunderbird71:
--- → unaffected
status-thunderbird_esr68:
--- → affected
|
|
||
Comment 9•6 years ago
|
||
Comment on attachment 9092925 [details] [diff] [review]
Bug-1581317_learn-more-link_not-wroking.patch
Review of attachment 9092925 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, r=mkmelin
Attachment #9092925 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 68.0
|
|
||
Comment 10•6 years ago
|
||
TB 68.1.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/a87208899cbfdcf5e33fb96e6dbb60d47ccc1330
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
tracking-thunderbird_esr68:
--- → 69+
Resolution: --- → FIXED
|
|
Reporter | |
Comment 11•6 years ago
|
||
v.fixed 68.1.1 per walt
You need to log in
before you can comment on or make changes to this bug.
Description
•