Closed
Bug 1581405
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 19066 - Avoid spurious timeouts in websocket test.
Categories
(Testing :: web-platform-tests, task, P4)
Testing
web-platform-tests
Tracking
(firefox71 fixed)
RESOLVED
FIXED
mozilla71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 19066 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/19066
Details from upstream follow.
Josh Matthews <josh@joshmatthews.net> wrote:
Avoid spurious timeouts in websocket test.
If a test assertion fails, the rest of the code in that test step will not run. By changing the ordering, we ensure that the test does not timeout because the websocket is never closed the test condition fails.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d16798150a477f07134e883a51c8eadc8ecc216
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e704c088753edc02bc525595f6ea7ba8942a89f
Assignee | ||
Comment 3•5 years ago
|
||
Ran 2 tests and 4 subtests OK : 2 PASS : 2 FAIL : 2
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e2b4e76df02 [wpt PR 19066] - Avoid spurious timeouts in websocket test., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/e02a3d990ba6 [wpt PR 19066] - Update wpt metadata, a=testonly
Comment 5•5 years ago
|
||
bugherder landing |
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e2b4e76df02
https://hg.mozilla.org/mozilla-central/rev/e02a3d990ba6
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•