1581555 - When switching dynamically switching locales via 'requestedLocales', and error is throw and the touch bar does not update

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Mark Banner (:standard8)]

I was testing something for another bug, and noticed this.

STR

1. On latest nightly, install a language pack for a different locale, e.g. from http://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/linux-x86_64/xpi/ (note: they work for Mac as well).
2. Set the intl.multilingual.enabled and intl.multilingual.downloadEnabled preferences to true.
3. Restart Firefox.
4. Open the Browser Console, and enter Services.locale.requestedLocales = ["ro"] (use whichever locale you installed.

Expected Results

Touch bar changes languages, no errors.

Actual Results

TypeError: kBuiltInInputs.keys is not a functionMacTouchBar.js:309:54
Touch bar language doesn't change until restart.

Although dynamic switching is not supported at the moment, I'm guessing it will be once Fluent is fully rolled out, and we have functionality for this.

I suspect the fix is simple, though we should add a test if we can as well.

Comment 1

[Harry Twyford]

Attachment: Bug 1581555 - Allow dynamic location switching in the Touch Bar. r?spohl,mikedeboer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83762a3e8989
Allow dynamic location switching in the Touch Bar. r=spohl,mikedeboer

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/83762a3e8989

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out from Beta along with bug 1600356 to hopefully avoid hitting bug 1607140 in 73.0b1. Also backed out from m-c to see how it affects the crash rate on Nightly.

https://hg.mozilla.org/integration/autoland/rev/a97f3b887300873e59b17c35e09273609117dd83
https://hg.mozilla.org/releases/mozilla-beta/rev/5e0b8d38ddfa197c95c7ebefd853d6caeb6fc6ba

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efaa19655437
Allow dynamic location switching in the Touch Bar. r=spohl,mikedeboer

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/efaa19655437