Closed Bug 1581570 Opened 3 months ago Closed 3 months ago

bug in spocs placement which causes spocs to not display after a dismiss until next restart

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 71
Iteration:
71.2 - Sept 16 - 29
Tracking Status
firefox70 + verified
firefox71 + verified

People

(Reporter: thecount, Assigned: thecount)

References

(Blocks 1 open bug)

Details

(Keywords: github-merged)

Attachments

(3 files)

STR:

  1. Enable DS and ensure you can see two spocs, 1 in position 3 and 1 in position 5.
  2. Dismiss 1 of the spocs.
  3. refresh

expected: should now see only 1 spoc, the one you didn't dismiss
actual: both are gone. If you restart, it should show up as expected.

[Tracking Requested - why for this release]: revenue related to spocs.

This is a bug introduced only in 70.

Should be a small change.

Iteration: --- → 71.2 - Sept 16 - 29
Priority: -- → P1
Assignee: nobody → sdowne
Flags: qe-verify+
Duplicate of this bug: 1584163

Gavin/Nan - can you make sure this gets uplifted into Beta 70 ASAP?

Flags: needinfo?(najiang)
Flags: needinfo?(gsuntop)
Blocks: 1584299

Sure. Once it lands in nightly, I'll request QA and beta uplift.

Flags: needinfo?(najiang)

Thanks, Nan!

Flags: needinfo?(gsuntop)

Hi Andreea,

We're landing the hotfix (bug 1584299) for the issue that you identified in bug 1584163.

Could you please verify it once bug 1584299 lands in nightly?

Thank you very much!

Flags: needinfo?(acupsa)
Status: NEW → RESOLVED
Closed: 3 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

I have verified this issue on Firefox Nightly 71.0a1 (Build ID: 20190927094817) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.
The sponsored cards are no longer dismissed when:

  • Dismissing a top site
  • Bookmarking any card from the Recommended by Pocket and Highlights section
  • Saving to Pocket any card from the Recommended by Pocket and Highlights section
  • Dismissing any card from the Recommended by Pocket and Highlights section
  • Archiving in Pocket any card from the Recommended by Pocket and Highlights section
  • Deleting from Pocket any card from the Recommended by Pocket and Highlights section
  • Removing bookmark from a card from the Recommended by Pocket and Highlights section
  • Bookmarking or removing a bookmark from any other website while not being on the about:newtab page.
Status: RESOLVED → VERIFIED
Flags: needinfo?(acupsa)

Can you request uplift to beta please?

Flags: needinfo?(sdowne)

Nan, Can you request uplift to beta please?

Flags: needinfo?(sdowne) → needinfo?(najiang)

Comment on attachment 9096916 [details]
Bug 1581570 - Spocs placement bug impacting non placements fixed

Beta/Release Uplift Approval Request

  • User impact if declined: SPOCS won't be working properly in 70.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It a bugfix and has been verified by QA.
  • String changes made/needed: None
Flags: needinfo?(najiang)
Attachment #9096916 - Flags: approval-mozilla-beta?

Comment on attachment 9096916 [details]
Bug 1581570 - Spocs placement bug impacting non placements fixed

OK for uplift for beta 11.

Attachment #9096916 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified this issue on Firefox Beta 70.0b11 (Build ID: 20190930132843) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.
The sponsored cards are no longer dismissed when:

  • Dismissing a top site
  • Bookmarking any card from the Recommended by Pocket and Highlights section
  • Saving to Pocket any card from the Recommended by Pocket and Highlights section
  • Dismissing any card from the Recommended by Pocket and Highlights section
  • Archiving in Pocket any card from the Recommended by Pocket and Highlights section
  • Deleting from Pocket any card from the Recommended by Pocket and Highlights section
  • Removing bookmark from a card from the Recommended by Pocket and Highlights section
  • Bookmarking or removing a bookmark from any other website while not being on the about:newtab page.
You need to log in before you can comment on or make changes to this bug.