1581578 - Focus styling isn't visible on trees in some scenarios (tabbing to the tree doesn't highlight the first item, navigating items with Ctrl+Up/Down)

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[u601362]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Open Firefox, browse to any page.
Press Ctrl+H (opens history), place cursor into the history search field, press tab key on keyboard two times.

Actual results:

Selected item is "today". But UI does not highlight this item

Expected results:

Either a dotted line or colorized background should indicate which is the focused item.

Comment 1

[Mark Banner (:standard8)]

It looks like the focus isn't set up correctly somehow. Opening the sidebar and tabbing to the tree seems to give focus to the entire tree, but the first item is not selected.

You can press left or right-arrow to expand it. Pressing up or down arrows gives the expected highlight.

This also affects the bookmarks sidebar as well as the history one.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=98d17facfe0093c4120cedd656d82b46822c1964&tochange=c8c488989a62c9ad8805569062c89ff74e641418

Regressed by: c8c488989a62c9ad8805569062c89ff74e641418 Tim Nguyen — Bug 1469287 - Implement new shared tree styling. r=dao

Before landing Bug 1469287, at least focus outline is indicated for the first treechildren.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for 70 but we could still take a patch in 71.

Comment 5

[Brian Grinstead [:bgrins]]

It seems like this is a general problem with trees based on Bug 1616843. Another STR from https://bugzilla.mozilla.org/show_bug.cgi?id=1616843#c0:

Steps to reproduce:

Trying to navigate in a tree (like bookmarks view) with keyboard, and moving around without selection (ie. with <ctrl>up/down).

Actual results:

No visual feedback except that the scroll area may move if we go far enough or if we open a sub-tree.

Expected results:

We should see something like the usual dotted-line outline.

Comment 6

[Brian Grinstead [:bgrins]]

Tim, do you have any idea which rule removed in https://hg.mozilla.org/mozilla-central/rev/c8c488989a62 might have caused this? Alternatively, I'm wondering if you found some workflow to test this in bug 1469287 - there's no indication of the focused item in the DOM/devtools even when it's working properly so it makes it hard to debug.

Comment 7

[Tim Nguyen :ntim]

(In reply to Brian Grinstead [:bgrins] from comment #6)

Tim, do you have any idea which rule removed in https://hg.mozilla.org/mozilla-central/rev/c8c488989a62 might have caused this?

Very likely: https://hg.mozilla.org/mozilla-central/rev/c8c488989a62#l26.47

Alternatively, I'm wondering if you found some workflow to test this in bug 1469287 - there's no indication of the focused item in the DOM/devtools even when it's working properly so it makes it hard to debug.

I can't remember on top of my head, but I recall this was more easily reproducible on Linux.

Comment 8

[Alex ARNAUD]

(In reply to Tim Nguyen :ntim from comment #7)

(In reply to Brian Grinstead [:bgrins] from comment #6)

Tim, do you have any idea which rule removed in https://hg.mozilla.org/mozilla-central/rev/c8c488989a62 might have caused this?

Very likely: https://hg.mozilla.org/mozilla-central/rev/c8c488989a62#l26.47

Alternatively, I'm wondering if you found some workflow to test this in bug 1469287 - there's no indication of the focused item in the DOM/devtools even when it's working properly so it makes it hard to debug.

I can't remember on top of my head, but I recall this was more easily reproducible on Linux.

Do you want a patch from us for that? We already have a patch for it that works. It's just getting the same patch as before.

Comment 9

[Tim Nguyen :ntim]

(In reply to Alex ARNAUD from comment #8)

(In reply to Tim Nguyen :ntim from comment #7)

(In reply to Brian Grinstead [:bgrins] from comment #6)

Tim, do you have any idea which rule removed in https://hg.mozilla.org/mozilla-central/rev/c8c488989a62 might have caused this?

Very likely: https://hg.mozilla.org/mozilla-central/rev/c8c488989a62#l26.47

Alternatively, I'm wondering if you found some workflow to test this in bug 1469287 - there's no indication of the focused item in the DOM/devtools even when it's working properly so it makes it hard to debug.

I can't remember on top of my head, but I recall this was more easily reproducible on Linux.

Do you want a patch from us for that? We already have a patch for it that works. It's just getting the same patch as before.

Feel free to submit one and request review from me or dao.

Comment 10

[Jonathan Michalon]

Attachment: Bug 1581578 - Re-introduce focus styling on trees r=ntim

Comment 11

[Jonathan Michalon]

Attachment: Bug 1581578 - Re-introduce focus styling on trees r=ntim

Comment 12

[Jonathan Michalon]

Attachment: Bug 1581578 - Re-introduce focus styling on trees r=ntim

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0148a0391d8
Re-introduce focus styling on trees r=ntim

Comment 14

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b0148a0391d8