Should Rhino support octal escape sequences in regexps?

VERIFIED FIXED in 1.5R4

Status

VERIFIED FIXED
16 years ago
15 years ago

People

(Reporter: pschwartau, Assigned: rogerl)

Tracking

other
1.5R4
x86
All

Details

(Reporter)

Description

16 years ago
This is the Rhino version of SpiderMonkey bug 141078. 
The testcase is:

        mozilla/js/tests/ecma_3/RegExp/octal-001.js

Octal escape sequences in regexps were accepted in ECMA-262 Edition 2
but deprecated in ECMA-262 Edition 3. In bug 141078, SpiderMonkey has
decided to support octal escape sequences for backward compatiblity. 

I assume we want to keep the Rhino regexp engine in synch, so I am 
filing this bug to track this issue.
(Assignee)

Comment 1

16 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

16 years ago
Umm. Actually I got ahead of myself on this - Norris, did you have any thoughts
on whether 'tis better to pursue SpiderMonkey or ECMA3 compatibility here?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 3

16 years ago
There are now two testcases for this bug:

        mozilla/js/tests/ecma_3/RegExp/octal-001.js
        mozilla/js/tests/ecma_3/RegExp/octal-002.js

Both are currently passing with the patch Roger has committed.

Comment 4

16 years ago
I think this can be closed now as fixed, right?
(Assignee)

Comment 5

16 years ago
I don't see why not.
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

16 years ago
Marking Verified Fixed.

Both testcases above are still passing in Rhino, both in interpreted
and compiled mode -
Status: RESOLVED → VERIFIED

Comment 7

15 years ago
Targeting as resolved against 1.5R4
Target Milestone: --- → 1.5R4
You need to log in before you can comment on or make changes to this bug.