Closed Bug 158159 Opened 22 years ago Closed 22 years ago

Should Rhino support octal escape sequences in regexps?

Categories

(Rhino Graveyard :: Core, defect)

Product:
Rhino Graveyard
Component:
Core
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: pschwartau, Assigned: rogerl)

Details

This is the Rhino version of SpiderMonkey bug 141078. 
The testcase is:

        mozilla/js/tests/ecma_3/RegExp/octal-001.js

Octal escape sequences in regexps were accepted in ECMA-262 Edition 2
but deprecated in ECMA-262 Edition 3. In bug 141078, SpiderMonkey has
decided to support octal escape sequences for backward compatiblity. 

I assume we want to keep the Rhino regexp engine in synch, so I am 
filing this bug to track this issue.
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Umm. Actually I got ahead of myself on this - Norris, did you have any thoughts
on whether 'tis better to pursue SpiderMonkey or ECMA3 compatibility here?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
There are now two testcases for this bug:

        mozilla/js/tests/ecma_3/RegExp/octal-001.js
        mozilla/js/tests/ecma_3/RegExp/octal-002.js

Both are currently passing with the patch Roger has committed.
I think this can be closed now as fixed, right?
I don't see why not.
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Marking Verified Fixed.

Both testcases above are still passing in Rhino, both in interpreted
and compiled mode -
Status: RESOLVED → VERIFIED
Targeting as resolved against 1.5R4
Target Milestone: --- → 1.5R4
You need to log in before you can comment on or make changes to this bug.