158159 - Should Rhino support octal escape sequences in regexps?

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Phil Schwartau]

This is the Rhino version of SpiderMonkey bug 141078. 
The testcase is:

        mozilla/js/tests/ecma_3/RegExp/octal-001.js

Octal escape sequences in regexps were accepted in ECMA-262 Edition 2
but deprecated in ECMA-262 Edition 3. In bug 141078, SpiderMonkey has
decided to support octal escape sequences for backward compatiblity. 

I assume we want to keep the Rhino regexp engine in synch, so I am 
filing this bug to track this issue.

Comment 1

[rogerl (gone)]

Fix checked in.

Comment 2

[rogerl (gone)]

Umm. Actually I got ahead of myself on this - Norris, did you have any thoughts
on whether 'tis better to pursue SpiderMonkey or ECMA3 compatibility here?

Comment 3

[Phil Schwartau]

There are now two testcases for this bug:

        mozilla/js/tests/ecma_3/RegExp/octal-001.js
        mozilla/js/tests/ecma_3/RegExp/octal-002.js

Both are currently passing with the patch Roger has committed.

Comment 4

[Igor Bukanov]

I think this can be closed now as fixed, right?

Comment 5

[rogerl (gone)]

I don't see why not.

Comment 6

[Phil Schwartau]

Marking Verified Fixed.

Both testcases above are still passing in Rhino, both in interpreted
and compiled mode -

Comment 7

[Igor Bukanov]

Targeting as resolved against 1.5R4