1581611 - Support the content_scripts value in the content_security_policy dictionary

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Shane Caraveo (:mixedpuppy)]

The "content_scripts" allows extensions to define a default csp for content scripts.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1581611 Part 1: add content_scripts to the extension content_security_policy

This WIP patch adds support for including content_scripts CSP in the extensions
manifest, along with all interfaces necessary to access the CSP value. This does not
implement actual use of the CSP for content scripts.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1581611 Part 2: apply content script csp

Comment 3

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ebcb52528fa96b5f37fd6485c237688407bfbf0

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe275de6b514d38ef140e2ed1aaf04b9e9d09c2d

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a56f917583a6
Part 1: add content_scripts to the extension content_security_policy r=rpl,bzbarsky
https://hg.mozilla.org/integration/autoland/rev/53390b20df64
Part 2: apply content script csp r=robwu,ckerschb

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a56f917583a6
https://hg.mozilla.org/mozilla-central/rev/53390b20df64

Comment 7

[Miruna Curtean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Comment 8

[Shane Caraveo (:mixedpuppy)]

There are tests

Comment 10

[Rob Wu [:robwu]]

The content_security_policy.content_scripts key got removed in a patch to bug 1594234, https://hg.mozilla.org/mozilla-central/rev/4baef7adb4a4576fa743792179f62794a5f6f1e0 with the following comment:

Support for content_security_policy.isolated_world (a.k.a. content_security_policy.content_scripts)
has been removed for consistency with
https://chromium.googlesource.com/chromium/src.git/+/345390adf6505881f84da2351c3e4fc1b06dac26%5E%21/