1581645 - Limit Inline Preview to Nightly and DevEdition

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P2)

Description

[:Harald Kirschner :digitarald]

Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1574553#c3 .

Comment 1

[Jason Laster [:jlast]]

Attachment: beta-pref-v1.patch

Beta/Release Uplift Approval Request

• User impact if declined: the debugger will be 30% slower when stepping
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): we have tested inline preview disabled in the debugger
• String changes made/needed:

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9093166 [details] [diff] [review]
beta-pref-v1.patch

OK for uplift for beta 9.

Comment 3

[Andreea Pavel [:apavel]]

For future references please correct the bug number in the commit also.
The patch failed to apply correctly (hunks failed), please check if the changes are correct in the landed revision.

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/63c5e3ccf355

Comment 5

[Alexandru Michis [:malexandru]]

Backed out changeset 63c5e3ccf355 for causing failures in browser_parsable_script.js

Backout link: https://hg.mozilla.org/releases/mozilla-beta/rev/896bb86a6cb2995245a431de09299c1890e06f45

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=testfailed%2Cbusted%2Cexception&tochange=896bb86a6cb2995245a431de09299c1890e06f45&fromchange=bbfbeee4593de9ea47385d88f2a109685aff233f&searchStr=%28bc&selectedJob=267921182

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267921182&repo=mozilla-beta&lineNumber=3201

[task 2019-09-23T09:04:56.272Z] 09:04:56 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_script.js | Script error reading jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/defaults/preferences/debugger.js: SyntaxError: private fields are not currently supported -
[task 2019-09-23T09:04:56.272Z] 09:04:56 INFO - Stack trace:
[task 2019-09-23T09:04:56.272Z] 09:04:56 INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2019-09-23T09:04:56.273Z] 09:04:56 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_script.js:parsePromise/promise</xhr.onreadystatechange:88
[task 2019-09-23T09:04:56.273Z] 09:04:56 INFO - Checking script jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/chrome/devtools/modules/devtools/client/memory/utils.js
[task 2019-09-23T09:04:56.273Z] 09:04:56 INFO - Checking script jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/chrome/devtools/modules/devtools/client/memory/dominator-tree-lazy-children.js
[task 2019-09-23T09:04:56.274Z] 09:04:56 INFO - Checking script jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/chrome/devtools/modules/devtools/client/jsonview/components/HeadersPanel.js
[task 2019-09-23T09:04:56.274Z] 09:04:56 INFO - Checking script jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/chrome/devtools/modules/devtools/client/inspector/flexbox/reducers/flexbox.js
[task 2019-09-23T09:04:56.274Z] 09:04:56 INFO - Checking script jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/chrome/browser/content/pocket/panels/js/tmpl.js
[task 2019-09-23T09:04:56.274Z] 09:04:56 INFO - Checking script jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/chrome/browser/content/pocket/panels/js/sendtomobile.js
[task 2019-09-23T09:04:56.276Z] 09:04:56 INFO - Checking script jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/chrome/browser/content/browser/customizableui/panelUI.js
[task 2019-09-23T09:04:56.277Z] 09:04:56 INFO - Checking script jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/chrome/devtools/modules/devtools/shared/fronts/actor-registry.js
[task 2019-09-23T09:04:56.277Z] 09:04:56 INFO - Checking script jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/chrome/devtools/modules/devtools/server/actors/webconsole/listeners/content-process.js

Comment 6

[Jason Laster [:jlast]]

I apologize, it looks like this pref had a syntax error. I'll push a simplified patch now

Comment 7

[Jason Laster [:jlast]]

Attachment: beta-pref-v2.patch

Beta/Release Uplift Approval Request

• User impact if declined:
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7cb6568eb69b