158173 - Bugs caused by checkin for 126600

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Mike Kowalski]

This checkin caused a dialog and some help files to not match the new wording.
This patch fixes that problem.

Comment 1

[Mike Kowalski]

Attachment: patch

Comment 2

[Mike Kowalski]

Attachment: patch

This patch fixes some issues.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Get jatin to approve these.

Comment 4

[Mike Kowalski]

Jatin, I changed the words in these files to match the new wording. Do you
approve of these?

Comment 5

[Jatin Billimoria]

Looks good except this sentence you suggest:
"Please note that Quick Launch will start up when the user's session starts."
User session is a jargon term and make not be understood by some users.

My suggested wording:
"If enabled, Quick Launch will start whenever the user starts Mozilla."

I would also double check to make sure &brandShortName; can be used in help. Ian
([e-mail]) would know about that.

Comment 6

[timeless]

jatin: we're not talking about mozilla sessions, we're talking about windows
sessions.

http://www.microsoft.com/windowsxp/home/evaluation/tours/htmltour/start_ending.htm

quicklaunch runs when your session starts, which happens when you log in.
however in win9x, windows often logs the user in automatically.  you can *not*
say when the computer boots, because it's just wrong. especially on nt where
many services do run when the computer boots, and mozilla does *not* behave like
that -- it could, but no one has made that kind of quick launcher yet.  also if
you were to say when the computer boots then there are problems with what
happens when you log off (mozilla quits) and then log back in again (my w98
laptop automatically logs me in at boot, but i can and do log off and back in --
no password), at which point, *if* the user account is configured to run mozilla
-turbo, mozilla will prepare quicklaunch.  Of course not all windows profiles
have to have turbo enabled (requiring that would be a serious bug).

Comment 7

[Jatin Billimoria]

My revised wording, based on timeless's comments:
"If enabled, Quick Launch will start when the user starts Windows."

Comment 8

[Mike Kowalski]

Attachment: fix

Comment 9

[timeless]

Comment on attachment 97143 [details] [diff] [review]
fix

ok, it took me a second read but that works for me.
r=timeless

Comment 10

[jag (Peter Annema)]

Jatin: are you okay with these changes?

Comment 11

[Jatin Billimoria]

attachment 97143 [details] [diff] [review] looks good
SR=jatin

Comment 12

[jag (Peter Annema)]

Comment on attachment 97143 [details] [diff] [review]
fix

sr=jag then

Comment 13

[Mike Kowalski]

checked in.

Comment 14

[Grace Bush]

verified Mozilla build 202091804

Comment 15

[Boris Zbarsky [:bzbarsky]]

This caused regression bug 170031