Closed Bug 1581738 Opened 5 years ago Closed 5 years ago

Error objects with non-string stack property fail to render in Reps

Categories

(DevTools :: Shared Components, defect, P1)

All
Unspecified
defect

Tracking

(firefox71 verified)

VERIFIED FIXED
Firefox 71
Tracking Status
firefox71 --- verified

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

Steps to reproduce

  1. Open the console
  2. Evaluate
x = new Error("sd");
x.stack = undefined;
x;

Expected results

I can see the error object in the console output

Actual results

An Invalid object string is rendered


When the stack isn't a string (or a longstring), we
don't try to parse anything.
A test is added to ensure we don't regress.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0db7327fb12
Fix ErrorRep for Error objects with non-string stack property. r=Honza.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Confirmed issue with 71.0a1 (2019-09-16).
Fix verified with 71.0b8 on Windows 10, macOS 10.13.6, Ubuntu 16.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Hardware: Unspecified → All
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: