1581753 - Improve one-off search button layout in very narrow windows

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Cristian Fogel [:cfogel]]

Attachment: search_notResponsive.png

Affected versions

• 70.0b7, 71.0a1 (2019-09-05) ;

Affected platforms

• Windows 10, Ubuntu 18.40, macOS 10.12;

Steps to reproduce

1. Launch Firefox ;
2. Resize the browser to @ 1/4 width of the screen;
3. Click to open the address bar;

Expected result

• One-of search options are displayed in the screen;

Actual result

• The dropdown has a min-width that is fixed and does not take in account the resize;
• buttons get truncated instead of being shifted into a visible position(space is available for it);

Regression range

• Potential regressor: 1561894

Additional notes

• attached screenshot with the issue;

Comment 1

[Cristian Fogel [:cfogel]]

Adding Harry for a second opinion; in case this issue can be fixed with another existing bug.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Cristian Fogel, QA [:cfogel] from comment #0)

Affected versions

• 70.0b7, 71.0a1 (2019-09-05) ;

This appears to be an old Nightly, please update.

Comment 3

[Cristian Fogel [:cfogel]]

Attachment: 09.16.png

Good point.
However, while with 71.0a1 (2019-09-16) the buttons are somewhat in order but the text before them is still fixed and taking up allot of the available space.

Comment 4

[Harry Twyford]

This is working as intended in comment 3's screenshot. I'm cc'ing Verdi just so he's aware of the UX here.

Comment 6

[Harry Twyford]

Verdi produced a spec for this that resizes with the page: https://firefox.michaelverdi.com/squish/. The minimum row width should match the length of the localized string.

Comment 7

[Dão Gottwald [:dao]]

I'm going to post a simple upliftable patch that I think addresses the main concern here and file a followup for verdi's more complex layout proposal.

Comment 8

[Dão Gottwald [:dao]]

Attachment: Bug 1581753 - Improve one-off search button layout in narrow windows. r=mak

Comment 9

[Marco Bonardo [:mak]]

Please remember to file the follow-up today, and make it block the megabar, we must meetup to discuss the path forward.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6ceaf18bea3
Improve one-off search button layout in narrow windows. r=mak

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c6ceaf18bea3

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 9095544 [details]
Bug 1581753 - Improve one-off search button layout in narrow windows. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: see comment 3
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: reduce the window width and type something in the address bar
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pretty simple fix
• String changes made/needed:

Comment 13

[Cristian Fogel [:cfogel]]

Attachment: verdiSpec.png

With 71.0a1(2019-09-29) the main issue seems to be addressed.
However as per comment 6, one more improvement can be made for this case; the buttons being pushed bellow the "This time, search with:" text when bellow a certain width.

Should we file a separate bug/enhancement for it?

Comment 14

[Dão Gottwald [:dao]]

(In reply to Cristian Fogel, QA [:cfogel] from comment #13)

With 71.0a1(2019-09-29) the main issue seems to be addressed.
However as per comment 6, one more improvement can be made for this case; the buttons being pushed bellow the "This time, search with:" text when bellow a certain width.

Should we file a separate bug/enhancement for it?

We already filed bug 1584253 on this.

Comment 15

[Cristian Fogel [:cfogel]]

Awesome, thank you for the prompt reply!
Marking the issue verified for nightly.
Keeping the QE flag until we get the beta-fix approved & checked.

Comment 16

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 9095544 [details]
Bug 1581753 - Improve one-off search button layout in narrow windows. r=mak

CSS fix, verified in nightly, let's uplift for beta 12.

Comment 17

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/337981f64cc6

Comment 18

[Cristian Fogel [:cfogel]]

Fix verified with 70.0b12 as well.