Closed Bug 1581777 Opened 4 months ago Closed 3 months ago

IterateCellCallback passes cell as separate void* pointer and trace kind

Categories

(Core :: JavaScript: GC, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: jonco, Assigned: a.munoz3327, NeedInfo)

Details

Attachments

(1 file)

Now we have GCCellPtr we should use that instead.

I'd like to work on this. Just so I understand, we need to

  1. replace the void *thing and JS::TraceKind tracekind arguments in the IterateCellCallback function typedef with a single GCCellPtr cellptr argument
  2. fix the arguments in all the calls to IterateCellCallback functions
  3. fix definitions for IterateCellCallback functions by replacing thing with cellptr.asCell() and tracekind with cellptr.kind()

Let me know if I misunderstood or missed anything so I can start working on this.

(In reply to Ayrton Muñoz from comment #1)
Great! Yes, that's correct on all counts.

passing cell to IterateCellCallback as GCCellPtr instead of separate void*
pointer and trace kind

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:a.munoz3327, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(a.munoz3327)
Assignee: nobody → a.munoz3327
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3dc2fd05ffe
IterateCellCallback passes cell as separate void* pointer and trace kind r=jonco
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.