Closed Bug 1581782 Opened 5 years ago Closed 5 years ago

Send to Devices menu is not showing device names correctly

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Firefox 68
ARM
Android
defect

Tracking

(firefox-esr68 verified)

VERIFIED FIXED
Firefox 68
Tracking Status
firefox-esr68 --- verified

People

(Reporter: mozilla.bugzilla, Assigned: petru)

References

Details

(Whiteboard: [fennec68.3])

Attachments

(4 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

Selected the Send to other devices option from the upper right hand menu in Firefox for Android

Actual results:

"Adam's Firefox on" is displayed twice, with no indication of which device is which

Expected results:

My currently signed in devices should have been shown

[Tracking Requested - why for this release]:

Priority: -- → P1

Can we verify this bug on a few other phones?

Hi!
I tested this on RC 68.1.1 and ESR 68.2b3 with Pixel 2 (Android 9), HTC 10 (Android 8.0.0), Huawei Honor 8 (Android 7.0) and I can reproduce the following issue:

Each time a device is connected to your account, is displayed in the share devices list. It is the same for the Devices and apps section from Manage account on Desktop and in the History->Synced devices category on phone.

The current device is shown only once in the list and that is expected, the rest of the devices are listed as "Firefox on ...", "Beta on ...", "Name's Firefox on ... ".

When tapping on Send to other devices, I see the list with the device's name correctly.

There are two issues filed for this:
https://bugzilla.mozilla.org/show_bug.cgi?id=1325304
https://bugzilla.mozilla.org/show_bug.cgi?id=1484164

voltagex: The issue is that you don't see the devices name or that a device is listed twice in the list? Thanks!

OS: Unspecified → Android
Hardware: Unspecified → ARM
Flags: needinfo?(voltagex)

(In reply to Eliza Balazs from comment #4)

voltagex: The issue is that you don't see the devices name or that a device is listed twice in the list? Thanks!

I think comment 0 and comment 1 were fairly clear. Comment 1 shows that the name for the devices is has a long name after the "on" part, so I suspect the problem is that Fennec is truncating the name because the last word can't entirely fit. I can't reproduce this easily (I'm struggling to get Fennec to refresh the device list after changing a name) but I suspect reproducibility has less to do with the phone itself and more to do with a combination of the names of the devices and the resolution of the screen in use.

Eliza, can you please try and reproduce what happens when the name of the target device is too large to fit on a single line?

Flags: needinfo?(voltagex) → needinfo?(eliza.balazs)

Hi!
I tested this on RC 68.1.1 and ESR 68.2b3 with Samsung Galaxy Note 8 (Android 9), Pixel 2 (Android 9), HTC 10 (Android 8.0.0), Prestigio Grace X5 (Android 4.4.2) synced with Firefox on Windows 10 and I can see the devices name if the device name is longer than usual. In some cases only a part of the name is shown.
Screenshot: https://drive.google.com/file/d/1oDoTAOgK8Y_fNrl7GYvGY2nAi-O3W-5o/view?usp=sharing

Flags: needinfo?(eliza.balazs)

Thanks! Can you please tell me what the full name of the top device shown was? I just want to check there were characters after the last shown "2"

Flags: needinfo?(eliza.balazs)

Hello! For the top device, that was the entire name. For the fourth device, the name was: "Beta on Pixel 2 pixel 2 pixel 2 pixel 2 pixel 2 pixel 2".

Flags: needinfo?(eliza.balazs)

(In reply to Eliza Balazs from comment #8)

Hello! For the top device, that was the entire name.

That seems like a nice coincidence because it fits perfectly - could you please re-test with the last word being too long to fit? ie, no spaces. For example, the same name as shown there but with a few extra "2" characters added.

For the fourth device, the name was: "Beta on Pixel 2 pixel 2 pixel 2 pixel 2 pixel 2 pixel 2".

Notice for that one there should be more "pixel 2"s shown - there's room for a "p" but it is not shown - hence my suspicion that entire words are not shown when the name is too long.

Flags: needinfo?(eliza.balazs)

I tested the scenario from Comment 9 and if one more character is added, the last word from the device name is not displayed.
Screenshot: https://drive.google.com/file/d/1qKTm12BKGxAD68aFNXK9ieK2ZFvBEcsz/view
This could be related with the available space when changing the device name.
I will mark this issue as NEW. Thanks!

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(eliza.balazs)

Talked about this with Stefan in the recent triage.
A simple solution would be to use Autosizing TextViews
(in which case having a minTextSize close to what we're using now (to not break the UX) would probably not resolve the issue)
OR
We could use maxLines="2" to allow for the device name to occupy two rows if needed.

Assignee: nobody → brad.arant
Assignee: brad.arant → petru.lingurar
Status: NEW → ASSIGNED

This would allow for longer names to be displayed on up to 2 rows and so
eliminate any confusion for device names starting with the same schema.

Here is a before and after comparison for my patch.
Showing the device names on max 2 lines can indeed help reduce confusion when multiple device names start with the same schema.

Try build with my changes on top of esr68https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6b86b98f14413d313b80183c89c5418be0e399f
Try build with my changes on top of esr 68 tip - https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c98b9a2b928601809cb11829979236ef3d051c6
Please test that a longer device name is now shown on two rows giving the possibility to better identify the device.

Flags: qe-verify+

Hi!
I tested the try build, provided in Comment 14, with OnePlus 5T (Android 9), Samsung Galaxy S8 (Android 9), Google Pixel 2 (Android 9), synced with Firefox on Windows 10 and the device name is shown on two rows.
On OnePlus 5T (Android 9) I noticed that the device name is too close to the right side of the pop-up window.
Screenshot: https://drive.google.com/file/d/1zyE8M83y8kG6XbXnedyXWWJHv9M3anWx/view

Flags: qe-verify+

Thanks Eliza!
I think it would've been possible to have the device name right up to the dialog's right margin before my patch also
But indeed fixing this while here would be nice.
A new try-build which includes the device name on two rows and an end margin - https://treeherder.mozilla.org/#/jobs?repo=try&revision=df62a98c6f273b97dba6a420188bd3a80e1f58a2

Flags: qe-verify+

I tested the build from Comment 17 with OnePlus 5T (Android 9), Samsung Galaxy S8 (Android 9), Google Pixel 2 (Android 9), synced with Firefox on Windows 10.
The device name is on two rows and the end margin issue is gone.
Petru: Thanks for the quick fix!

Flags: qe-verify+

Comment on attachment 9103427 [details]
Bug 1581782 - Show device name in share menu on max 2 lines; r?VladBaicu

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: UX issue preventing users from sharing to the right device.
  • User impact if declined: In cases of longer devices names starting with the same text the end part which is different may be hidden leaving users not knowing which device is which.
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small targeted change, verified by QA.
  • String or UUID changes made by this patch:
Attachment #9103427 - Flags: approval-mozilla-esr68?
Whiteboard: [fennec68.2.x]

Comment on attachment 9103427 [details]
Bug 1581782 - Show device name in share menu on max 2 lines; r?VladBaicu

Fixes a UI issue making it difficult to share to the correct device in some cases. Approved for Fennec 68.3b3.

Attachment #9103427 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+

Looks great - thank you for this patch!

Ryan, we would like to ship this for 68.2.1.

Looks like our comments crossed paths. 68.3 is also fine.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Hi, verified as fixed on Firefox Beta 68.3b3 with Google Pixel 3 XL(Android 9), OnePlus 6T (Android 9), Samsung Galaxy S9 (Android 8.0.0) and Sony Xperia Z5(Android 7.0).
I will leave the status as it is until the fix will be present on Firefox Release.

Whiteboard: [fennec68.2.x] → [fennec68.2.1]
Whiteboard: [fennec68.2.1] → [fennec68.3]

Verified as fixed on 68.3.0 RC.
Device: Samsung Galaxy Tab S3 (Android 8.0).

Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: