1581850 - Selector highlighter doesn't show up when hovering selectors in Style Editor

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect, P3)

Description

[Razvan Caliman [:rcaliman]]

Attachment: source-editor-selector-highlighter.mp4

The "mousemove" event listeners need to be added to the iframe's contentWindow instead of directly to it.

This is a regression which happened after Firefox 69 (last known good version).

Steps to reproduce

• Navigate to https://bugzilla.mozilla.org/home
• Open DevTools, switch to Style Editor
• Select the index.css stylesheet from the left column
• Find the CSS rule with the selector #welcome
• Move the mouse over the selector

Expected

After a short delay, the target element ("Welcome to Bugzilla" element) on the page should be highlighted with a box (the selector highlighter). I have attached a video demo with the expected result.

Actual

The target element is not highlighted.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1581850 - Ensure target elements are highlighted when hovering selectors in DevTools Style Editor. r=pbro

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

Razvan, you have an r+ patch attached to this bug, will you land it in 71? Thanks

Comment 3

[Patrick Brosset <:pbro>]

Chiming in: the fix is really tiny and would be very safe for 70, but I don't think it's really worth an uplift to be honest.

Comment 4

[Razvan Caliman [:rcaliman]]

I have not landed this yet because the fix triggered test failures elsewhere in the Style Editor which I have not yet addressed. Once I do that, I will follow-up with this bug.

Comment 5

[Razvan Caliman [:rcaliman]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=287db20e5f874d8db11d7276fcd333da6225cc93

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7bd0696e0c8
Ensure target elements are highlighted when hovering selectors in DevTools Style Editor. r=pbro

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/e7bd0696e0c8