1581879 - Artifacts when zooming text on webrender on android

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Jamie Nicol [:jnicol]]

This is a regression from bug 1580063. When zooming on a page with text (such as mozilla.org) there are thin horizontal and vertical lines moving across the text. (Perhaps at picture cache tile boundaries, given the regressing bug).

I can see this on my Pixel 2 (Adreno 5xx) and OnePlus 6 (6xx).

Any ideas Glenn?

Comment 1

[Glenn Watson [:gw]]

Would you be able to get a screenshot / video of the effect? And maybe enable the picture caching debug option, and see if the dirty rect borders line up with where the artifacts are?

Comment 2

[Glenn Watson [:gw]]

I wonder is this might be fixed by https://phabricator.services.mozilla.com/D46247 when it lands?

Comment 3

[Kris Taeleman (:ktaeleman)]

Tried it on a Pixel 3 and didn't see the artifacts mentioned.
The only remaining artifacts when zooming fast is items not being fully rendered and popping in.

Comment 4

[Jamie Nicol [:jnicol]]

Did you enable webrender (and restart) first? I can still reproduce on today's nightly, and "items not being fully rendered and popping in" sounds more like zooming without webrender.

Comment 5

[Kris Taeleman (:ktaeleman)]

Argh... I was assuming webrender was enabled... sorry, you are right, it's still occurring. :/

Comment 6

[Glenn Watson [:gw]]

Attachment: Bug 1581879 - Artifacts when zooming text on webrender on android.

Fix scissor rect being incorrect during pinch zoom due to floating
point inaccuracies.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b008fcd2c17
Artifacts when zooming text on webrender on android. r=jnicol,nical

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4b008fcd2c17