1581958 - Add a new "Break on..." submenu for the watchpoints context menu

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Miriam]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36

Steps to reproduce:

Right click on an item in the Scopes pane to pull up the watchpoints context menu.

Actual results:

Currently there are two items: "Pause on get" and "Pause on set."

Expected results:

The watchpoint menu should have a "Break on..." menu item which creates the submenu items "Get" and "Set."

Comment 1

[Miriam]

Attachment: Add sub-menu to watchpoints context menu r=jlast

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4827f64f1e18
Add sub-menu to watchpoints context menu r=jlast

Comment 3

[Raul Gurzau (:RaulG)]

Backed out changeset 4827f64f1e18 (bug 1581958) for failing at browser_misused_characters_in_strings.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0b29aabf3ae7392c7cdb60271439b540b1a02d2e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=4827f64f1e1826b0579e196453409e5dc5b755d7&selectedJob=267503793

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267503793&repo=autoland&lineNumber=1447

Log snippet:
task 2019-09-19T20:45:13.251Z] 20:45:13 INFO - TEST-START | browser/base/content/test/static/browser_misused_characters_in_strings.js
[task 2019-09-19T20:45:13.667Z] 20:45:13 INFO - TEST-INFO | started process screencapture
[task 2019-09-19T20:45:13.836Z] 20:45:13 INFO - TEST-INFO | screencapture: exit 0
[task 2019-09-19T20:45:13.836Z] 20:45:13 INFO - Buffered messages logged at 20:45:13
[task 2019-09-19T20:45:13.837Z] 20:45:13 INFO - Entering test bound checkAllTheProperties
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - TEST-PASS | browser/base/content/test/static/browser_misused_characters_in_strings.js | Found 147 .properties files to scan for misused characters -
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - Buffered messages finished
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_misused_characters_in_strings.js | jar:file:///Users/cltbld/tasks/task_1568925716/build/application/Firefox%20Nightly.app/Contents/Resources/browser/omni.ja!/chrome/en-US/locale/en-US/devtools/client/debugger.properties with key=watchpoints.submenu has a misused ellipsis. Strings with an ellipsis should use the Unicode … character instead of three periods. -
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - Stack trace:
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_misused_characters_in_strings.js:testForError:145
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_misused_characters_in_strings.js:testForErrors:182
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_misused_characters_in_strings.js:checkAllTheProperties:222
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1350
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1385
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1213
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-09-19T20:45:13.838Z] 20:45:13 INFO - Leaving test bound checkAllTheProperties

Comment 4

[Miriam]

@g

Got it, thanks. I pushed a change to fix this and it should work now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2139163abec7
Add sub-menu to watchpoints context menu r=jlast

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2139163abec7