Land non-DOM test for bug 1561567 Introduce rope-walking conversion from JS strings to UTF-8 in a byte span
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
The tests for bug 1561567 landed with bug 1561573 and rely on DOM APIs. This is for landing a JS-only port.
From bug 1561567 comment 37:
The test works for me locally, but fails on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2ec39c0628bd3e23cf8fd981b9c6766caee7b57&selectedJob=267010608Why does it get a different compartment configuration on try? What can I do about it?
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
(In reply to Henri Sivonen (:hsivonen) from comment #0)
The test works for me locally, but fails on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2ec39c0628bd3e23cf8fd981b9c6766caee7b57&selectedJob=267010608Why does it get a different compartment configuration on try? What can I do about it?
JS reftests run in both the browser and JS shell, the Jx jobs on Treeherder are the browser runs. To get isSameCompartment there you need something like this: https://searchfox.org/mozilla-central/rev/1d0e84d2ec2843924bc6e5ed6658f93439e12351/js/src/tests/non262/Promise/allSettled.js#58-60
In the shell the test might fail (for a different reason) if you pass the --more-compartments flag (this flag is used in automation too..). Maybe just remove the assertion or use newGlobal({sameCompartmentAs: this}).
|
|
||
Comment 3•5 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #2)
In the shell the test might fail (for a different reason) if you pass the
--more-compartmentsflag (this flag is used in automation too..). Maybe just remove the assertion or usenewGlobal({sameCompartmentAs: this}).
Oh nvm, the test isn't creating a global, it's just using newRope. In that case just removing the assertion or copying the isSameCompartment code I linked should be fine.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
Still fails. Are there more compartments in the reftest case? Would be appropriate to make the test exit early in the reftest case?
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
||
Updated•5 years ago
|
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08f14e478d36 Test bug 1561567 JS_EncodeStringToUTF8BufferPartial without DOM code. r=jandem
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Description
•