Remove addons.cdn.mozilla.net from the list of separatedMozillaDomains
Categories
(Core :: DOM: Content Processes, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox74 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
Attachments
(3 files)
Once Bug 1574372 is fixed, we can back out Bug 1556655
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
With Bug 1574372 landed we can back this out.
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Since you had had some experience with this feature, when this bug lands on Nightly, could you double check it works for me?
STR:
- Use Nightly. Any OS, any platform.
- Set privacy.resistFingerprinting to true
- Set privacy.resistFingerprinting.block_mozAddonManager to true
- Set browser.tabs.remote.separatePrivilegedMozillaWebContentProcess to true
- Go to AMO
- Install any add-on
If it installs successfully, we're good to go.
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b59dd4db036e Remove addons.cdn.mozilla.net from the list of separatedMozillaDomains r=mattwoodrow
Comment 4•4 years ago
|
||
Comment 5•4 years ago
|
||
I verified the steps specified above https://bugzilla.mozilla.org/show_bug.cgi?id=1582132#c2 with FF74.0a1 (Win10):
- I set privacy.resistFingerprinting to true (this pref is available in the list but initially is bolean false)
- I add and set on true privacy.resistFingerprinting.block_mozAddonManager - this pref is not available
- I let browser.tabs.remote.separatePrivilegedMozillaWebContentProcess on true (this pref is already available and set on true on Nightly)
- I load addons.mozilla.org and open an add-ons detail page to install it, am example https://addons.mozilla.org/en-US/firefox/addon/clean-youtube-no-ads/
Testing results:
Observing the about:addons page the addon looks installed.
The detail page of the add-on shows the state as "+Add to Firefox" in blue instead of "Remove". Refreshing page or reopening the page in another tab had the same results - the buttons state is not correct. I can click it and the install process will be repeated again and again (but the addon is already installed as about:addons page is showing).
Comment 6•4 years ago
|
||
I noticed that if I set privacy.resistFingerprinting.block_mozAddonManager on false and go to the add-on’s page and refresh it the correct state is displayed which is Remove
for installed add-ons and Enable
for installed but disabled add-ons.
I could reproduce the issue with extensions and themes available on AMO prod - addons.mozilla.org
Should this issue be reopened or file a separate one ?
Assignee | ||
Comment 7•4 years ago
|
||
Thank you! Yes that is all the intended behavior. With mozAddonManager blocked, AMO isn't able to query for the install state of an AddOn; therefore it will not know to show 'Enable/Remove' for installed Add-Ons and will instead show the same, initial 'Install' button. This is a known bug/papercut that we don't expect to be addressed anytime soon.
I'm going to mark this Verified - thanks!
Description
•