1582158 - The order of the buttons from the confirmation dialog is reversed on Linux

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: Linux confirmation dialog.png

[Affected Versions]:

• Nightly 71.0a1

[Affected Platforms]

• All Linux

[Prerequisites]

• Have a profile with at least one saved login.

[Steps to reproduce]:

1. Open the latest Nightly browser with the profile from prerequisites.
2. Click on a saved login.
3. Click the "Delete" button.
4. Observe the order of the "Delete" and "Cancel" buttons from the "Delete this login?" dialog.

[Expected results]:

• The order of the buttons are based on the OS ("Delete" button on the right part and the "Cancel" button on the left).

[Actual results]:

• The buttons don't respect the OS order ("Delete" button on the left part and the "Cancel" button on the right).

[Notes]:

• The issue is also reproducible for the "Discard unsaved changes?" dialog.
• Attached a screenshot of the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

It is my understanding that on Linux we show the Confirmation button first, then the Cancel button. Can you post a screenshot of a system dialog with the buttons in the opposite order? I think we usually defer to Ubuntu as representative of Linux in cases like this.

Comment 2

[Cosmin Muntean [:cmuntean], Ecosystem QA]

For example the "Bookmark" panel. On Linux (Arch and Ubuntu) the "Cancel" button is on the left and the "Done" button is on the right (see this screenshot). On Windows are reversed.
Also, on Linux (Arch and Ubuntu) the buttons from the "Quit and close tabs?" panel are displayed in the following order: "Cancel" on the left and "Close tabs" on the right(see this screenshot). On Windows are reversed.

Comment 3

[Matthew N. [:MattN]]

Mass removing [skyline] and [passwords:management] from about:logins bugs which are no longer useful.

Comment 4

[Karan Sapolia]

Hello all, I would like to work on this one. For another example, on Fedora 31 (Linux) I see the 'Remove' button on the left and the 'Cancel' button on the right ( see screenshot ).

Comment 5

[Maria Heres, inactive, contact Ecosystem QA]

This issue is also reproducible for the “Remove all <#> logins?” modals as seen in this screenshot. Tested using 88.0b4 FR (Build ID: 20210328185936) using Linux Mint 20.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 7

[Sergey Galich [:serg]]

Attachment: Bug 1582158 - The order of the buttons from the confirmation dialog is reversed on Linux r=dimi!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c727418adf9
The order of the buttons from the confirmation dialog is reversed on Linux r=dimi

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8c727418adf9

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 106.0a1 build (Build ID: 20220918214503) on Ubuntu 20.04 x64.

• The order of buttons from the “Remove this login?”, “Remove all <no> logins?” and “Discard unsaved changes?” pop-ups are no longer reversed on Linux.