1582186 - Gecko 'metrics.yaml' is not picked up in a-c when doing dependency substitution

Status: RESOLVED WONTFIX

(Data Platform and Tools :: Glean: SDK, defect, P3)

Description

[Alessio Placitelli [:Dexter]]

For some reason, when pointing Android Components to the locally built GeckoView as shown in this guide, the metrics.yaml does not get fetched.

This means that it's either not being packed by the Gecko build system (assuming, in this case, the AAR is still assembled) or failed to fetch by the Glean script used in engine-gecko-nightly.

Comment 1

[Alessio Placitelli [:Dexter]]

This is simple to verify: adding a metric to the metrics.yaml in Gecko does not result in a new entry in engine-gecko-nightly/build/generated/source/glean/<variant>/kotlin/GleanGeckoMetricsMapping.kt

Comment 2

[Nick Alexander :nalexander [he/him]]

It's my guess that you are seeing Gradle caching which I expect to be alleviated by SNAPSHOT builds.

To verify:

1. apply the commit from that ticket
2. ./mach build
3. ./gradlew ... as usual in a-c

With luck you'll see the new metrics.yaml processed. If not, a ./gradlew ... --debug (attached, it's huge) will help understand the caching layer.

Comment 3

[Alessio Placitelli [:Dexter]]

Hey Jamie, any chance you could try that out?

Comment 4

[Jamie Nicol [:jnicol]]

Unfortunately that didn't work. Even after doing a ./gradlew clean before ./gradlew assembleDebug.

Attached is the output from assembleDebug. (you weren't kidding about it being huge!): https://send.firefox.com/download/5ac19a9f7c3da8c7/#WcQLqit0YUaxc0HschCSEA

Comment 5

[Jamie Nicol [:jnicol]]

Attachment: 0001-use-local-gecko.patch

As a workaround to this, I removed the dependencySubstitutions.geckoviewTopsrcdir line from local.properties, and instead manually added the maven repo to android-components' build.gradle, and overrode the Gecko.geckoview_nightly version.

Attached is the patch.

After doing this, android-components picks up my metrics from gecko's metrics.yaml.

Comment 6

[Jamie Nicol [:jnicol]]

Whoops, definitely didn't mean to assign this to me! That's the limit of my gradle knowledge!

Comment 7

[Alessio Placitelli [:Dexter]]

Moving this to backlog. Nick Alexander is away :)