1582196 - Get rid of NS_ERROR_RANGE_ERR

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Boris Zbarsky [:bzbarsky]]

It's causing us to have spec-compliance bugs because people get confused and use NS_ERROR_RANGE_ERR when they're supposed to throw a RangeError.

For example, ImageBitmap::Create throws this instead of an actual RangeError.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1582196 part 1. Stop using NS_ERROR_RANGE_ERR in createImageBitmap. r=baku

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1582196 part 2. Stop using NS_ERROR_RANGE_ERR in SVGTransform. r=jwatt

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1582196 part 3. Stop using NS_ERROR_RANGE_ERR and NS_ERROR_TYPE_ERR in payments code. r=edenchuang

The changes to the return type of MerchantValidationEvent::init are because
Result doesn't allow having an ErrorResult (or any other type without a copy
constructor) as its error type. Plus we would have had the impedance mismatch
between Result<Ok, nsresult> (which is what URL resolution on the document
returns) and Result<Ok, ErrorResult> anyway.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1582196 part 4. Get rid of NS_ERROR_RANGE_ERR. r=peterv

The two remaining consumers don't seem to depend on actually using this
specific nsresult in any way.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05a8a4e72917
part 1.  Stop using NS_ERROR_RANGE_ERR in createImageBitmap.  r=baku
https://hg.mozilla.org/integration/autoland/rev/4bf2eafe1afd
part 2.  Stop using NS_ERROR_RANGE_ERR in SVGTransform.  r=jwatt
https://hg.mozilla.org/integration/autoland/rev/7a73a025a5ab
part 3.  Stop using NS_ERROR_RANGE_ERR and NS_ERROR_TYPE_ERR in payments code.  r=edenchuang
https://hg.mozilla.org/integration/autoland/rev/8357c5978e4c
part 4.  Get rid of NS_ERROR_RANGE_ERR.  r=peterv

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19231 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/05a8a4e72917
https://hg.mozilla.org/mozilla-central/rev/4bf2eafe1afd
https://hg.mozilla.org/mozilla-central/rev/7a73a025a5ab
https://hg.mozilla.org/mozilla-central/rev/8357c5978e4c

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot