about:welcome Join modal should not dismiss when you click on the background
Categories
(Firefox :: Messaging System, defect, P1)
Tracking
()
People
(Reporter: abenson, Assigned: pdahiya)
References
Details
(Keywords: github-merged, Whiteboard: [skyline])
Attachments
(2 files)
52 bytes,
text/x-github-pull-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
Clicking outside of the Join Modal on about:welcome shouldn't close the modal. We should treat this like a traditional modal where the user must take action from the modal options itself. This would eliminate any errant clicks which dismiss the modal.
Comment 1•3 years ago
|
||
make sure the 'esc' key will also close the modal
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
[Tracking Requested - why for this release]:
Small change enforcing modal behavior to be dismissed only on explicit click of 'Start Browsing' button or press of 'Esc' key
Assignee | ||
Updated•3 years ago
|
Comment 4•3 years ago
|
||
Comment 5•3 years ago
|
||
I have verified that this issue is no longer reproducible with the latest Firefox Nightly (71.0a1 Build ID - 20191006214844) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Join" modal is no longer dismissed when clicking outside the modal.
Assignee | ||
Comment 6•3 years ago
|
||
Click outside dialog should not close modal
Assignee | ||
Comment 7•3 years ago
|
||
Comment on attachment 9099375 [details]
Bug 1582242 - Modal should not close when clicked outside the dialog
Beta/Release Uplift Approval Request
- User impact if declined: about:welcome dialog closes when user clicks outside which is not an expected behavior of modal dialogs.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: STR:
- Open about:welcome
- Click outside modal should not close the dialog
- Click on dismiss icon, Esc key should close the dialog
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small patch that's been verified in nightly
- String changes made/needed: None
Comment on attachment 9099375 [details]
Bug 1582242 - Modal should not close when clicked outside the dialog
Fix for about:welcome behavior, OK for uplift for beta 14.
Updated•3 years ago
|
Comment 9•3 years ago
|
||
bugherderuplift |
Comment 10•3 years ago
|
||
I have verified that this issue is no longer reproducible with the latest Firefox Beta (70.0b14 Build ID - 20191010142853) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Join" modal is no longer dismissed when clicking outside the modal.
Description
•