1582242 - about:welcome Join modal should not dismiss when you click on the background

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Aaron Benson]

Clicking outside of the Join Modal on about:welcome shouldn't close the modal. We should treat this like a traditional modal where the user must take action from the modal options itself. This would eliminate any errant clicks which dismiss the modal.

Comment 1

[Tim Spurway [:tspurway]]

make sure the 'esc' key will also close the modal

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5323

Comment 3

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:
Small change enforcing modal behavior to be dismissed only on explicit click of 'Start Browsing' button or press of 'Esc' key

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/be0251572777

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (71.0a1 Build ID - 20191006214844) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Join" modal is no longer dismissed when clicking outside the modal.

Comment 6

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1582242 - Modal should not close when clicked outside the dialog

Click outside dialog should not close modal

Comment 7

[Punam Dahiya [:pdahiya]]

Comment on attachment 9099375 [details]
Bug 1582242 - Modal should not close when clicked outside the dialog

Beta/Release Uplift Approval Request

• User impact if declined: about:welcome dialog closes when user clicks outside which is not an expected behavior of modal dialogs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR:

1. Open about:welcome
2. Click outside modal should not close the dialog
3. Click on dismiss icon, Esc key should close the dialog

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch that's been verified in nightly
• String changes made/needed: None

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9099375 [details]
Bug 1582242 - Modal should not close when clicked outside the dialog

Fix for about:welcome behavior, OK for uplift for beta 14.

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d4b48f0460bd

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (70.0b14 Build ID - 20191010142853) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Join" modal is no longer dismissed when clicking outside the modal.