Closed Bug 1582242 Opened 3 months ago Closed 2 months ago

about:welcome Join modal should not dismiss when you click on the background

Categories

(Firefox :: Messaging System, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 71
Iteration:
71.2 - Sept 16 - 29
Tracking Status
firefox70 + verified
firefox71 --- verified

People

(Reporter: abenson, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

(Keywords: github-merged, Whiteboard: [skyline])

Attachments

(2 files)

Clicking outside of the Join Modal on about:welcome shouldn't close the modal. We should treat this like a traditional modal where the user must take action from the modal options itself. This would eliminate any errant clicks which dismiss the modal.

make sure the 'esc' key will also close the modal

Assignee: nobody → pdahiya
Blocks: 1564149
Iteration: --- → 71.2 - Sept 16 - 29
Priority: -- → P1

[Tracking Requested - why for this release]:
Small change enforcing modal behavior to be dismissed only on explicit click of 'Start Browsing' button or press of 'Esc' key

Whiteboard: [skyline]
Flags: qe-verify+
Blocks: 1586093
Status: NEW → RESOLVED
Closed: 2 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (71.0a1 Build ID - 20191006214844) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Join" modal is no longer dismissed when clicking outside the modal.

Status: RESOLVED → VERIFIED
Regressions: 1586769

Click outside dialog should not close modal

Comment on attachment 9099375 [details]
Bug 1582242 - Modal should not close when clicked outside the dialog

Beta/Release Uplift Approval Request

  • User impact if declined: about:welcome dialog closes when user clicks outside which is not an expected behavior of modal dialogs.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: STR:
  1. Open about:welcome
  2. Click outside modal should not close the dialog
  3. Click on dismiss icon, Esc key should close the dialog
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small patch that's been verified in nightly
  • String changes made/needed: None
Attachment #9099375 - Flags: approval-mozilla-beta?

Comment on attachment 9099375 [details]
Bug 1582242 - Modal should not close when clicked outside the dialog

Fix for about:welcome behavior, OK for uplift for beta 14.

Attachment #9099375 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (70.0b14 Build ID - 20191010142853) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Join" modal is no longer dismissed when clicking outside the modal.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.