1582299 - 8,600 instances of "This method is lossy. Use GetCanonicalPath !" emitted from xpcom/io/nsLocalFileWin.cpp during windows10-64 debug testing

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[Eric Rahm [:erahm]]

8634 WARNING: This method is lossy. Use GetCanonicalPath !: file xpcom/io/nsLocalFileWin.cpp, line 3200

This warning [1] shows up in the following test suites:

   696 - test-windows10-64/debug-web-platform-tests-wdspec-e10s-2 Wd2
   444 - test-windows10-64/debug-web-platform-tests-wdspec-e10s-1 Wd1
   396 - test-windows10-64/debug-test-verify-e10s-1 TV1
   276 - test-windows10-64/debug-reftest-e10s-3 R3
   270 - test-windows10-64/debug-reftest-e10s-2 R2
   252 - test-windows10-64/debug-test-verify-e10s-3 TV3
   249 - test-windows10-64/debug-web-platform-tests-e10s-14 wpt14
   213 - test-windows10-64/debug-marionette-e10s Mn
   204 - test-windows10-64/debug-web-platform-tests-reftests-e10s-4 Wr4
   192 - test-windows10-64/debug-web-platform-tests-e10s-5 wpt5
   189 - test-windows10-64/debug-web-platform-tests-e10s-16 wpt16
   189 - test-windows10-64/debug-web-platform-tests-reftests-e10s-1 Wr1
   186 - test-windows10-64/debug-web-platform-tests-e10s-17 wpt17
   183 - test-windows10-64/debug-web-platform-tests-reftests-e10s-3 Wr3
   180 - test-windows10-64/debug-test-verify-wpt-e10s-2 TVw2
   180 - test-windows10-64/debug-test-verify-wpt-e10s-1 TVw1
   177 - test-windows10-64/debug-web-platform-tests-e10s-2 wpt2
   171 - test-windows10-64/debug-web-platform-tests-e10s-8 wpt8
   168 - test-windows10-64/debug-web-platform-tests-e10s-10 wpt10
   168 - test-windows10-64/debug-web-platform-tests-e10s-9 wpt9
   168 - test-windows10-64/debug-web-platform-tests-e10s-7 wpt7
   165 - test-windows10-64/debug-web-platform-tests-e10s-15 wpt15
   162 - test-windows10-64/debug-web-platform-tests-e10s-3 wpt3
   159 - test-windows10-64/debug-web-platform-tests-reftests-e10s-5 Wr5
   159 - test-windows10-64/debug-web-platform-tests-e10s-6 wpt6
   159 - test-windows10-64/debug-web-platform-tests-e10s-4 wpt4
   159 - test-windows10-64/debug-web-platform-tests-e10s-11 wpt11
   156 - test-windows10-64/debug-web-platform-tests-reftests-e10s-2 Wr2
   147 - test-windows10-64/debug-web-platform-tests-e10s-18 wpt18
   144 - test-windows10-64/debug-test-verify-wpt-e10s-3 TVw3
   144 - test-windows10-64/debug-test-verify-gpu-e10s TVg
   138 - test-windows10-64/debug-web-platform-tests-e10s-12 wpt12
   132 - test-windows10-64/debug-mochitest-chrome-1proc-2 c2
   132 - test-windows10-64/debug-mochitest-chrome-1proc-1 c1
   129 - test-windows10-64/debug-web-platform-tests-e10s-1 wpt1
   108 - test-windows10-64/debug-mochitest-e10s-5 5
    99 - test-windows10-64/debug-mochitest-e10s-3 3
    99 - test-windows10-64/debug-mochitest-chrome-1proc-3 c3
    93 - test-windows10-64/debug-mochitest-e10s-2 2
    93 - test-windows10-64/debug-mochitest-e10s-4 4
    90 - test-windows10-64/debug-mochitest-e10s-1 1
    84 - test-windows10-64/debug-firefox-ui-functional-local-e10s en-US
    81 - test-windows10-64/debug-mochitest-browser-chrome-e10s-5 bc5
    78 - test-windows10-64/debug-mochitest-browser-chrome-e10s-4 bc4
    75 - test-windows10-64/debug-mochitest-browser-chrome-e10s-3 bc3
    75 - test-windows10-64/debug-mochitest-browser-chrome-e10s-1 bc1
    75 - test-windows10-64/debug-mochitest-browser-chrome-e10s-6 bc6
    42 - test-windows10-64/debug-telemetry-tests-client-e10s c
    39 - test-windows10-64/debug-mochitest-media-spi-e10s mda
    39 - test-windows10-64/debug-mochitest-media-e10s mda
    36 - test-windows10-64/debug-mochitest-devtools-chrome-e10s-5 dt5
    27 - test-windows10-64/debug-mochitest-devtools-chrome-e10s-1 dt1
    27 - test-windows10-64/debug-mochitest-devtools-chrome-e10s-4 dt4
    21 - test-windows10-64/debug-marionette-gpu-e10s MnG
    18 - test-windows10-64/debug-mochitest-devtools-chrome-e10s-2 dt2
    18 - test-windows10-64/debug-mochitest-gpu-e10s gpu
    18 - test-windows10-64/debug-mochitest-devtools-chrome-e10s-3 dt3
    15 - test-windows10-64/debug-mochitest-webgl1-core-e10s gl1c
     3 - test-windows10-64/debug-mochitest-remote-e10s remote
     3 - test-windows10-64/debug-marionette-media-e10s MnM
     3 - test-windows10-64/debug-mochitest-a11y-1proc a11y
     3 - test-windows10-64/debug-xpcshell-e10s-2 X2
     3 - test-windows10-64/debug-jsreftest-e10s-3 J3
     3 - test-windows10-64/debug-mochitest-webgl2-core-e10s gl2c
     3 - test-windows10-64/debug-mochitest-webgl2-ext-e10s-2 gl2e2
     3 - test-windows10-64/debug-mochitest-webgl2-ext-e10s-3 gl2e3
     3 - test-windows10-64/debug-mochitest-webgl2-ext-e10s-4 gl2e4
     3 - test-windows10-64/debug-mochitest-webgl1-ext-e10s gl1e
     3 - test-windows10-64/debug-firefox-ui-functional-remote-e10s en-US
     3 - test-windows10-64/debug-jsreftest-e10s-1 J1
     3 - test-windows10-64/debug-gtest-1proc GTest
     3 - test-windows10-64/debug-crashtest-e10s C
     3 - test-windows10-64/debug-jsreftest-e10s-2 J2
     3 - test-windows10-64/debug-mochitest-webgl2-ext-e10s-1 gl2e1

It shows up in 1658 tests. A few of the most prevalent:

  1674 - [e10s] Shutdown
   297 -        Shutdown
   138 - [e10s] file:///Z:/task_1568804856/build/tests/reftest/tests/layout/reftests/bugs/1241631-1.html == file:///Z:/task_1568804856/build/tests/reftest/tests/layout/reftests/bugs/1241631-1-ref.html
    81 - [e10s] /webdriver/tests/new_session/create_alwaysMatch.py
    81 - [e10s] /webdriver/tests/new_session/create_firstMatch.py
    57 -        browser/components/shell/test/test_headless_screenshot.html
    36 - [e10s] /css/motion/offset-path-ray-contain-002.html
    36 - [e10s] /css/motion/offset-path-ray-contain-003.html
    36 - [e10s] /css/motion/offset-path-ray-003.html
    36 - [e10s] /css/motion/offset-path-ray-002.html

[1] https://hg.mozilla.org/mozilla-central/annotate/e71921b729c6/xpcom/io/nsLocalFileWin.cpp#l3200

Comment 1

[Barret Rennie [:barret] (they/them)]

nsLocalFile::GetNativeCanonicalPath no longer exists.