Closed Bug 1582328 Opened 3 months ago Closed 3 months ago

Get better error messages when a mozmill test file has a problem

Categories

(Thunderbird :: Testing Infrastructure, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file, 1 obsolete file)

At the moment, if a test file throws an exception when loaded (for example it tries to import from a URL that doesn't exist and throws NS_ERROR_FILE_NOT_FOUND), the log shows no error message and not even the file name.

This can be improved by sending better information to the log writer. I can't actually get just the exception message itself (the exception object is weird), so I'll send the whole string representation.

Result:

SUMMARY-UNEXPECTED-FAIL | testCategoryColors.js | testCategoryColors.js::<TOP_LEVEL>
  EXCEPTION: [Exception... "File error: Not found"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: file:///home/geoff/mozilla/mozilla-central/obj-artifact/_tests/mozmill/stage/preferences/testCategoryColors.js :: <TOP_LEVEL> :: line 9"  data: no]
    at: testCategoryColors.js line 9
Attached patch 1582328-mozmill-errors-1.diff (obsolete) — Splinter Review
Attachment #9093765 - Flags: review?(mkmelin+mozilla)

Great, even the core code can't decide if it's filename or fileName. :-/

Attachment #9093765 - Attachment is obsolete: true
Attachment #9093765 - Flags: review?(mkmelin+mozilla)
Attachment #9093802 - Flags: review?(mkmelin+mozilla)
Attachment #9093802 - Flags: review?(mkmelin+mozilla) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/14db01bcabd2
Get better error messages when a mozmill test file has a problem; r=mkmelin DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.