1582328 - Get better error messages when a mozmill test file has a problem

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, enhancement)

Description

[Geoff Lankow (:darktrojan)]

At the moment, if a test file throws an exception when loaded (for example it tries to import from a URL that doesn't exist and throws NS_ERROR_FILE_NOT_FOUND), the log shows no error message and not even the file name.

This can be improved by sending better information to the log writer. I can't actually get just the exception message itself (the exception object is weird), so I'll send the whole string representation.

Result:

SUMMARY-UNEXPECTED-FAIL | testCategoryColors.js | testCategoryColors.js::<TOP_LEVEL>
  EXCEPTION: [Exception... "File error: Not found"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: file:///home/geoff/mozilla/mozilla-central/obj-artifact/_tests/mozmill/stage/preferences/testCategoryColors.js :: <TOP_LEVEL> :: line 9"  data: no]
    at: testCategoryColors.js line 9

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1582328-mozmill-errors-1.diff

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1582328-mozmill-errors-2.diff

Great, even the core code can't decide if it's filename or fileName. :-/

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/14db01bcabd2
Get better error messages when a mozmill test file has a problem; r=mkmelin DONTBUILD