1582471 - [Protections Panel] The focus indicator overlaps the toggle button

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: Screenshot_55.png

Affected versions

• 71.0a1 (BuildId:20190919094654)
• 70.0b7 (BuildId:20190916074538)

Affected platforms

• Windows 10 64bit

Unaffected platforms

• macOS 10.13.6
• Ubuntu 18.04 64bit.

Steps to reproduce

1. Launch Firefox.
2. Open any web page.
3. Click the shield icon to open the protections panel.
4. Press the “Tab” several times to focus on the TP switch.

Expected result
The focus indicator does not overlap the toggle button.

Actual result
The focus indicator overlaps the toggle button.

Regression Range
I don’t think that this is a regression

Notes
For further information regarding this issue please observe the attached screenshot.
I am reproducing this issue with 70.0b8 (provided in Bug 1578052 , comment 9) as well.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1582471 - Unset the CSS 'outline-offset' rule for the TP switch when it gets focused on Windows. r?nhnt11!

On Windows, there is a global CSS rule to set 'outline-offset' to -2px
on toolbarbuttons. We need to unset it on the TP switch button in order
to make the focus indicator to work correctly.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0add1eb7bd28
Unset the CSS 'outline-offset' rule for the TP switch when it gets focused on Windows. r=nhnt11

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0add1eb7bd28

Comment 4

[Tim Huang[:timhuang]]

Comment on attachment 9094118 [details]
Bug 1582471 - Unset the CSS 'outline-offset' rule for the TP switch when it gets focused on Windows. r?nhnt11!

Beta/Release Uplift Approval Request

• User impact if declined: The focus indicator would overlap the TP switch on Window.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Launch Firefox.

2. Open any web page.
3. Click the shield icon to open the protections panel.
4. Press the “Tab” several times to focus on the TP switch.
5. Check if the focus indicator overlaps the TP switch.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only adds one CSS rule. So, it's low risk.
• String changes made/needed: None

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9094118 [details]
Bug 1582471 - Unset the CSS 'outline-offset' rule for the TP switch when it gets focused on Windows. r?nhnt11!

Low risk one liner css patch, uplift approved for 70 beta 9, thanks.

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d52f0b133dd9

Comment 7

[Ciprian Georgiu, Desktop QA]

I was able to reproduce the issue using an affected Nightly build (2019-09-09), and by following the steps from comment 0.

The issue is verified fixed on latest Nightly 71.0a1 and Beta 70.0b9, under Windows 10 x64.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.