1582504 - SVGMarkerElement::SetOrientToAngle has an IsFinite check and exception that doesn't seem to be in the spec

Status: RESOLVED FIXED

(Core :: SVG, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

The spec at https://svgwg.org/svg2-draft/painting.html#__svg__SVGMarkerElement__setOrientToAngle is not too helpful in defining a processing model, but nothing in that processing model seems to involve throwing exceptions, and we definitely throw one in our implementation.

I looked at https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/svg/svg_marker_element.cc?l=145-149&rcl=40c35d22b802dc92af717153bc849b30f35c5356 and it doesn't seem to do any throwing, so this behavior isn't matched by Blink.

https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/svg/SVGMarkerElement.cpp?rev=249822#L129 doesn't throw, so no exception in Safari either.

Comment 1

[Robert Longson [:longsonr]]

I think this is a remnant of the pre-webidl implementation that passed through infinities. We don't want to allow infinite values as it can get the graphics backends into a broken state but if we can't actually pass them in, this check is redundant.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm.

So the argument here is a DOMSVGAngle, not a Web IDL double or float.

The Value() of a DOMSVGAngle can in fact be infinite, I think: you can SetValueInSpecifiedUnits() with a value which is finite in radians but which goes to Infinity when multiplied by 180/M_PI to get degrees, for example.

Comment 3

[Robert Longson [:longsonr]]

fixed by check in for bug 1836132