1582542 - Cannot send tabs

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Edouard Oger [:eoger]]

Getting this._fxai.currentAccountState.getSignedInUser is not a function.
Patch incoming.

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1582542 - Use getUserAccountData in FxA commands invoke.

Comment 2

[Ryan Kelly [:rfkelly]]

Is there a test we can add that would have caught this regression?

Comment 3

[Edouard Oger [:eoger]]

Probably, I wish we had e2e tests for Pairing and Send Tab that could catch these problems early. I have already requested the landing so I'll try not to disturb Lando.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c420af7f34af
Use getUserAccountData in FxA commands invoke. r=vladikoff

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c420af7f34af

Comment 6

[Miruna Curtean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it.
Thank you

Comment 7

[Edouard Oger [:eoger]]

You can validate by sending a tab from Desktop to Firefox Preview.

Comment 8

[Miruna Curtean]

Verified fixed by sending tabs from Windows Pro 10 64-bit and macOS Catalina 10.15 on FF 71.0b6 (20191031113544) and FF 72.0a1 (20191104214406) to Firefox Preview FF 70.0b15 (20191014032640) on android and in reverse.
After tapping on "Send tab to device" a "Sent!" notification pops up on device A (desktop) and on mobile a notification containing the name of the device it was sent from and the URL shows up.
Tapping on the notification open an article in the Firefox preview browser and a youtube link in the Youtube application.
To note that from Firefox Preview main page all open tabs can be shared simultaneously.
If the same tab is already opened on the sent device, the notification will be received and the page will be opened again.
To note that the timing of the notification varies, sometimes it can take a few seconds and other times it can take up to a minutes until it is received.