1582648 - The content of the tracking protection and identity panel is erased before the panel fades out, causes uneven animation

Status: RESOLVED WORKSFORME

(Firefox :: Site Identity, defect, P5)

Description

[Markus Stange [:mstange]]

On macOS, when an arrow panel disappears, it fades out with an animation. For most arrow panels in the browser UI, this animation looks smooth. But for the panels that come out of the buttons at the left end of the URL bar, the animation is uneven.

This seems to be what's happening:

1. The panel is rendered with all of its content and at full opacity.
2. Now the user dismisses the panel.
3. The panel content is instantly replaced with white, at 97% opacity.
4. The empty panel fades out.

What should happen instead is that the content should stay in the panel until the panel is completely invisible.

(This might just be a matter of replacing a "popuphiding" event listener with a "popuphidden" event listener.)

Comment 1

[Markus Stange [:mstange]]

Attachment: identity panel, fully visible

Comment 2

[Markus Stange [:mstange]]

Attachment: identity panel, content erased

Comment 3

[Markus Stange [:mstange]]

Attachment: identity panel, content erased and half faded out

Comment 4

[Markus Stange [:mstange]]

Attachment: tracking protection panel, fully visible

Comment 5

[Markus Stange [:mstange]]

Attachment: tracking protection panel, content mostly erased

Comment 6

[Markus Stange [:mstange]]

Attachment: tracking protection panel, content mostly erased and half faded out

Comment 7

[Johann Hofmann [:johannh]]

I can't really see the effect you're referring to, though maybe I'm doing something wrong. We're not doing any manual teardown in the front-end AFAIK. Could this be a widget bug?

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

I'm marking this P5 because it's a very hard to notice visual issue that will require some time to figure out, and likely not something we can prioritize soon. We can re-prioritize if new information comes up.

Comment 9

[(inactive) Nihanth Subramanya [:nhnt11]]

FWIW I can definitely see the issue - it was hard to spot at first but now I can't unsee it. It helps to concentrate on the arrow of the protections panel, it stays fully opaque and purple and contrasts with the rest of the panel once it whites out, making the issue more visible.

Comment 10

[Markus Stange [:mstange]]

This seems fixed now.