158266 - Mach-o build should use mac locale code

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Brian Ryner (not reading)]

Currently the mach-o build is using the unix locale code.  It should probably be
using the Mac locale code.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Tested that this compiles on mach-o and classic cfm builds.  Not sure how to
verify the functionality though.

Comment 2

[Simon Fraser [no longer active]]

Patch looks good, though it would be nice to be able to avoid the extra
alloctions. Since we know we're appending 2 pascal strings + 2, a stack buffer
of 514 bytes should always be enough.

Comment 3

[Brian Ryner (not reading)]

Yes, that's true.  I was trying to avoid wasting space.  But since it's
temporary and not all that large, it should be ok.

Comment 4

[Brian Ryner (not reading)]

Attachment: use a stack buffer

Comment 5

[Rui Xu]

code issue? QA -> yokoyama for now.

Comment 6

[Simon Fraser [no longer active]]

Comment on attachment 92031 [details] [diff] [review]
use a stack buffer

sr=sfraser

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 92031 [details] [diff] [review]
use a stack buffer

r=pink

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 92031 [details] [diff] [review]
use a stack buffer

a=asa (on behalf of drivers) for checkin to 1.1

Comment 9

[Brian Ryner (not reading)]

Checked into the trunk.  Do we want this on the Chimera branch now, or should we
wait until the next time we move the branch?