Closed Bug 1582661 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 19179 - [LayoutNG] Ignore margin when determining if a new-fc will fit in an oop.

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19179 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19179
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[LayoutNG] Ignore margin when determining if a new-fc will fit in an oop.

Previously we calculated layout opportunities by shrinking the available
child space by the child's margins.

This resulted in layout opportunities which were too small, and would
push the new formatting context down to the next opportunity.

This logic now allows margins to "overhang" a layout opportunity.

At the same time I refactored a lot of the code, as we were
adding/subtracting margins for different calculations. Hopefully this
is more readable!

Bug: 1003193
Change-Id: I6c05b050332afe9880ca7d9a5b426b4b94fde3f5

Reviewed-on: https://chromium-review.googlesource.com/1808661
WPT-Export-Revision: 751aec338ab55dc6b48688590cac62708b18a697

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 3 tests
PASS   : 3
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/12761dc5f613
[wpt PR 19179] - [LayoutNG] Ignore margins when determining if a new-fc will fit in a layout opportunity., a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.