[wpt-sync] Sync PR 19179 - [LayoutNG] Ignore margin when determining if a new-fc will fit in an oop.
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 19179 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/19179
Details from upstream follow.
Ian Kilpatrick <ikilpatrick@chromium.org> wrote:
[LayoutNG] Ignore margin when determining if a new-fc will fit in an oop.
Previously we calculated layout opportunities by shrinking the available
child space by the child's margins.This resulted in layout opportunities which were too small, and would
push the new formatting context down to the next opportunity.This logic now allows margins to "overhang" a layout opportunity.
At the same time I refactored a lot of the code, as we were
adding/subtracting margins for different calculations. Hopefully this
is more readable!Bug: 1003193
Change-Id: I6c05b050332afe9880ca7d9a5b426b4b94fde3f5Reviewed-on: https://chromium-review.googlesource.com/1808661
WPT-Export-Revision: 751aec338ab55dc6b48688590cac62708b18a697
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9bb6fef0c06157e7e0b3e8bb03a0d4a3e0a4330
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=7060507d7f53565dbb974f42ed476443bfec9e0f
Assignee | ||
Comment 3•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bffa01a5e410b119d483d77054ed5a3fce26b6cc
Assignee | ||
Comment 4•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc72d6bace37f0bdc3d6b7c734b7c605cdb00c96
Assignee | ||
Comment 5•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1a8f81384b956b78cbdee6ffb216488a5e495ce
Assignee | ||
Comment 6•5 years ago
|
||
Ran 3 tests PASS : 3
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/12761dc5f613 [wpt PR 19179] - [LayoutNG] Ignore margins when determining if a new-fc will fit in a layout opportunity., a=testonly
Comment 8•5 years ago
|
||
bugherder |
Description
•