Closed Bug 1582693 Opened 5 years ago Closed 4 years ago

Console should respect devtools.editor.autoclosebrackets preference

Categories

(DevTools :: Console, task, P2)

Product:
DevTools
Component:
Console
Type:
task

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

Bug 1582693 - Make console input respect the autoclose bracket pref. r=Honza.
47 bytes, text/x-phabricator-request
Details | Review

The preference is deliberately set to false in devtools/client/webconsole/components/Input/JSTerm.js#224

I think removing this would make the editor picks up the value of the pref.

The choice to not respect the setting was made in Bug 1490086, with a good reason to do so.

mh, so I wanted to test that again and it looks like I can't reproduce https://bugzilla.mozilla.org/show_bug.cgi?id=1490086#c0 anymore.
Maybe this was fixed in CodeMirror somehow.
So I guess we can try to honor the pref now.

We can mention this "new feature" in the what's new panel, and indicate this can be turned-off in the settings panel?
What do you think Harald?

Flags: needinfo?(hkirschner)

The setting was forced to false, but we should honor
the preference value instead.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

Yes, will add it to the list of quality of life improvements. Thanks for the heads up!

Flags: needinfo?(hkirschner)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a468b2dc3b0d
Make console input respect the autoclose bracket pref. r=Honza.

Backed out changeset a468b2dc3b0d (Bug 1582693) for devtools/client/webconsole/test/browser/browser_jsterm_ failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=dt8&fromchange=7ccb7b8c14eadc6f56971b26278d93bd2eb5ff2c&tochange=317e1d1f21a00fac8bbb93fe3f3e060ca4d4a9b2&selectedJob=284352369

Backout link: https://hg.mozilla.org/integration/autoland/rev/317e1d1f21a00fac8bbb93fe3f3e060ca4d4a9b2

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284352369&repo=autoland&lineNumber=4211

...
[task 2020-01-10T10:21:23.011Z] 10:21:23 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | undefined - correct ch -
[task 2020-01-10T10:21:23.012Z] 10:21:23 INFO - Check that the invoke tooltip is displayed when performing an element access
[task 2020-01-10T10:21:23.012Z] 10:21:23 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | Dialog has expected text content -
[task 2020-01-10T10:21:23.012Z] 10:21:23 INFO - Check that hitting Tab does invoke the getter and return its properties
[task 2020-01-10T10:21:23.013Z] 10:21:23 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | popup is open after Tab -
[task 2020-01-10T10:21:23.014Z] 10:21:23 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | popup has expected items -
[task 2020-01-10T10:21:23.015Z] 10:21:23 INFO - Checking jsterm state:
[task 2020-01-10T10:21:23.015Z] 10:21:23 INFO - window.foo.bar.baz[|
[task 2020-01-10T10:21:23.016Z] 10:21:23 INFO - Buffered messages finished
[task 2020-01-10T10:21:23.016Z] 10:21:23 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | console input has expected value - Got window.foo.bar.baz[], expected window.foo.bar.baz[
[task 2020-01-10T10:21:23.017Z] 10:21:23 INFO - Stack trace:
[task 2020-01-10T10:21:23.017Z] 10:21:23 INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-01-10T10:21:23.017Z] 10:21:23 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:checkInputValueAndCursorPosition:696
[task 2020-01-10T10:21:23.018Z] 10:21:23 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js:null:101
[task 2020-01-10T10:21:23.018Z] 10:21:23 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-01-10T10:21:23.018Z] 10:21:23 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-01-10T10:21:23.019Z] 10:21:23 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-01-10T10:21:23.019Z] 10:21:23 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-01-10T10:21:23.019Z] 10:21:23 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | undefined - correct line -
[task 2020-01-10T10:21:23.020Z] 10:21:23 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | undefined - correct ch -
[task 2020-01-10T10:21:23.020Z] 10:21:23 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | confirm tooltip is now closed -
[task 2020-01-10T10:21:23.020Z] 10:21:23 INFO - Checking jsterm state:
[task 2020-01-10T10:21:23.021Z] 10:21:23 INFO - window.foo.bar.baz["hello"]|
[task 2020-01-10T10:21:23.021Z] 10:21:23 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | console input has expected value -
[task 2020-01-10T10:21:23.022Z] 10:21:23 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | undefined - correct line -
[task 2020-01-10T10:21:23.022Z] 10:21:23 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-01-10T10:21:23.023Z] 10:21:23 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | undefined - correct ch - Got 26, expected 27
[task 2020-01-10T10:21:23.023Z] 10:21:23 INFO - Stack trace:
[task 2020-01-10T10:21:23.023Z] 10:21:23 INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-01-10T10:21:23.023Z] 10:21:23 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:checkInputValueAndCursorPosition:701
[task 2020-01-10T10:21:23.024Z] 10:21:23 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js:null:107
[task 2020-01-10T10:21:23.024Z] 10:21:23 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-01-10T10:21:23.024Z] 10:21:23 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-01-10T10:21:23.024Z] 10:21:23 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-01-10T10:21:23.024Z] 10:21:23 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-01-10T10:21:23.025Z] 10:21:23 INFO - Check that autocompletion work on a getter result
[task 2020-01-10T10:22:48.644Z] 10:22:48 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-01-10T10:22:48.644Z] 10:22:48 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | Test timed out -
[task 2020-01-10T10:22:49.627Z] 10:22:49 INFO - Removing tab.
[task 2020-01-10T10:22:49.628Z] 10:22:49 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-01-10T10:22:49.684Z] 10:22:49 INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-01-10T10:22:49.691Z] 10:22:49 INFO - GECKO(1168) | console.warn: "IGNORED REDUX ACTION:" ({type:"AUTOCOMPLETE_CLEAR"})
[task 2020-01-10T10:22:49.713Z] 10:22:49 INFO - Tab removed and finished closing
[task 2020-01-10T10:22:49.769Z] 10:22:49 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | The main process DebuggerServer has no pending connection when the test ends -
[task 2020-01-10T10:22:49.785Z] 10:22:49 INFO - GECKO(1168) | MEMORY STAT | vsize 20975752MB | residentFast 1773MB
[task 2020-01-10T10:22:49.786Z] 10:22:49 INFO - TEST-OK | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_getters_confirm.js | took 91238ms
....

Flags: needinfo?(nchevobbe)

forgot to update the patch before landing..

Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00a7a3d23fea
Make console input respect the autoclose bracket pref. r=Honza.

https://hg.mozilla.org/mozilla-central/rev/00a7a3d23fea

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Regressions: 1644662
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: