Closed Bug 1582697 Opened 4 months ago Closed 4 months ago

Default disableTask to true in create-store.js

Categories

(DevTools :: Shared Components, task, P3)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In Bug 1494680, we're adding an option to the create-store function so you can disable the task middleware (disableTask).

It's set to false by default as they're currently some panel that need it, but we should set it to true and override it from the panel the are broken without it.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

The disableTask options is renamed to enableTaskMiddleware,
which defaults to false.

This caused failure in the dom mutation breakpoint test, because
we weren't waiting until the call to the server to remove the
breakpoints were done.
It wasn't an issue before because this was handle by the task
middleware, which catch rejections.
We fix this by only dispatching the action when the breakpoints are
indeed removed. We also tweak to waitForAllElements helper to be
able to wait for a specific count of element (it used to resolve
when there was at least the specified count, which is not ideal
when trying to assert removal of an element).

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83ae51b03731
Don't add the task middleware by default in create-store. r=davidwalsh.
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.