1582713 - When What's New toolbar button is active the Overflow Menu position is changed in Customize Firefox

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: overflow_01.png

Affected versions

• 70.0b8 (20190902191027)
• 71.0a1 (20190919184237)

Affected platforms

• Windows 10x64
• Ubuntu 18.04
• macOS 10.14

Preconditions

• Make sure What's New toolbar button is active (if not open Fx with a new profile and wait like 5-7 min).

Steps to reproduce

1. Open Firefox and go to Customize Menu.
2. Observe the Overflow section on the top right.

Expected result

• Overflow Menu is correctly displayed under the expected icon.

Actual result

• Overflow Menu is displayed under What's New toolbar button.

Regression range

• Reproducible on Firefox 70.0a1(20190729095501). I will search for one ASAP.

Additional Notes

• Attached a screenshot.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hm. I wonder if we should be hiding that button while in Customize Mode (as I imagine it can't be customized via Customize Mode, considering its placement next to the appmenu button). That might be simplest option.

What do you think, r1cky?

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Passing it on to :andreio.

Comment 3

[Andrei Oprea [:andreio]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #1)

Hm. I wonder if we should be hiding that button while in Customize Mode (as I imagine it can't be customized via Customize Mode, considering its placement next to the appmenu button). That might be simplest option.

Thanks that's a good idea.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5322

Comment 5

[Andrei Oprea [:andreio]]

Attachment: Bug 1582713 - Hide the What's New button from the toolbar when in Customize mode

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdd3e554925b
Hide the What's New button from the toolbar when in Customize mode r=Gijs

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/bdd3e554925b

Comment 8

[Alexandru Trif, Desktop QA [:atrif]]

Hello! The issue is verified with Firefox 71.0a1 (20190925215653) on Windows 10x64, macOS 10.14 and Ubuntu 18.04. The What's New toolbar button is successfully hidden when entering the Customize menu.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Is this something we should uplift to Beta for Skyline?

Comment 10

[Andrei Oprea [:andreio]]

Comment on attachment 9094938 [details]
Bug 1582713 - Hide the What's New button from the toolbar when in Customize mode

Beta/Release Uplift Approval Request

• User impact if declined: UI regression in Customize mode
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS change that has been verified by QA
• String changes made/needed: n/a

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9094938 [details]
Bug 1582713 - Hide the What's New button from the toolbar when in Customize mode

Polish for skyline, css fix, verified in nightly.
OK for uplift for beta 12.

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/b75075fa08c9