1582738 - When importing saved Chrome passwords on mac, don't cause a keychain prompt if there are no rows to import

Status: VERIFIED FIXED

(Firefox :: Migration, defect, P3)

Description

[:Gijs (he/him)]

As of bug 1423714, we offer password importing from Chrome on macOS.

If there are no passwords in the DB, but the DB exists, we offer a checkbox for "saved passwords" importing in the import wizard. Using it will prompt for keychain access (twice, which is bug 1582486). We do this irrespective of how many rows of results we've gotten from the DB. We shouldn't do it if there's not been any results (or, ideally, if there haven't been results with the right encryption that we know how to deal with).

Comment 1

[Matthew N. [:MattN]]

Ah, good point… I thought I implemented it this way because I misread:

      if (!rows) {
        return;
      }

but that doesn't handle rows.length == 0.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1582738 - ChromeProfileMigrator: Don't initialize crypto if there are no rows. r=Gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34fc136a1cc1
ChromeProfileMigrator: Don't initialize crypto if there are no rows. r=Gijs

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/34fc136a1cc1

Comment 5

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Nightly 74.0a1 (Build ID: 20200129093157) on Mac 10.14.

• The Keychain pop-up is no longer displayed when importing logins from Chrome if there are no saved passwords.