Closed Bug 1582768 Opened 2 months ago Closed 2 months ago

Add UITour target for Logins and Passwords in the main menu

Categories

(Firefox :: Tours, enhancement, P1)

Desktop
All
enhancement

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- wontfix
firefox-esr68 --- wontfix
firefox69 --- wontfix
firefox70 ? fixed
firefox71 --- fixed

People

(Reporter: MattN, Assigned: MattN)

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(1 file)

Marketing wants to be able to point people to about:logins for Fx70 marketing but directly opening about:logins could lead to clickjacking issues (e.g. with the clipboard via copy buttons) and is a sensitive page so instead we will allow showing info panels or highlights on the Logins and Passwords main menu item.

To highlight the menu item without an animation use the following from an origin on the UITour allow list:

Mozilla.UITour.showHighlight("logins")

[Tracking Requested - why for this release]: Marketing request for Fx70.

Flags: qe-verify-
Attachment #9094211 - Attachment description: Bug 1582768 - Add UITour target for Logins and Passwords in the main menu. → Bug 1582768 - Add UITour target for Logins and Passwords in the main menu. r=jaws
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/ea74ac35e717
Add UITour target for Logins and Passwords in the main menu. r=jaws

Comment on attachment 9094211 [details]
Bug 1582768 - Add UITour target for Logins and Passwords in the main menu. r=jaws

Beta/Release Uplift Approval Request

  • User impact if declined: Marketing wouldn't be able to direct users to the new about:logins (you can't link directly to it).
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial patch which adds a selector to point to an existing menu item
  • String changes made/needed: None
Attachment #9094211 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Whiteboard: [passwords:management] [skyline]

Comment on attachment 9094211 [details]
Bug 1582768 - Add UITour target for Logins and Passwords in the main menu. r=jaws

Needed for Skyline; OK for uplift for beta 9 as discussed with MattN.
Let's verify in beta 9.

Attachment #9094211 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.