Closed
Bug 1582847
Opened 5 years ago
Closed 5 years ago
Compute typeInfo.RootedPointers before they are needed by addGCType
Categories
(Core :: JavaScript: GC, defect, P1)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
Details
Attachments
(1 file)
I was computing RootedPointers (eg AutoGCRooter subclasses) too late, so they weren't being taken into account. This should have resulted in about 55 hazards, except that there's another bug that prevented some things from being considered as holding GC pointers at all, so the hazards did not appear. I don't have any tests using affected types.
I'm going to hold off on adding tests for now, because they'll conflict with the big patch stack I'm trying to land at the moment. I will add some tests as part of that patch series instead.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d508d856dfc6 Compute typeInfo.RootedPointers before they are needed by addGCType r=jonco
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•