Closed Bug 1582901 Opened 5 years ago Closed 5 years ago

Improve stepping between frames

Categories

(Core Graveyard :: Web Replay, enhancement)

enhancement
Not set
normal

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

Details

Attachments

(1 file)

When paused at a location, we want to prefetch pause data for nearby points which the user can step to. The mechanism which does this is pretty crude: it only considers steps within the current frame, and doesn't consider whether the stepping points are ones which the step-over and reverse-step-over buttons will actually reach (it only looks for breakpoint positions instead of step start positions in the script). It would be nice to improve this by more carefully simulating the effects of pressing the stepping buttons. We can figure out which points the user will reach (well, probably reach, ignoring information associated with the server actors like which sources are black-boxed), and only generate pause data for those points. This avoids wasting work and allows fast stepping in and stepping out of frames. The attached patch also fixes a few issues that were slowing down stepping on jsfiddle, due to requests for information not included in the pause data.

Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd204006f2cc
Improve stepping between frames, r=jlast.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: