Closed Bug 1582936 Opened 6 months ago Closed 3 months ago

Footer Error in Thunderbird 68.1.0 hy-AM

Categories

(Thunderbird :: General, defect)

Desktop
Windows 8.1
defect
Not set

Tracking

(thunderbird_esr68 fixed)

RESOLVED FIXED
Thunderbird 68.0
Tracking Status
thunderbird_esr68 --- fixed

People

(Reporter: hrant.mozilla, Assigned: rjl)

Details

Attachments

(4 files)

Attached image Screenshot_10.jpg

Hello
In a new version of Thunderbird 68.1.0 (Armenian locale) Footer has an error message. Screenshot is attached.

Could that be related to an add-on? Or is there an error in the localisation? Also see bug 1580960 comment #1.

Component: Folder and Message Lists → hy-AM / Armenian
Product: Thunderbird → Mozilla Localizations
Version: 68 → unspecified

All add-ons are disabled after this update (duo to incompatibility).

I don't see any Errors on Pontoon: pontoon.mozilla.org/hy-AM/

Well, what you see in the picture are certainly some XUL errors. Some complaints in the vicinity of <key id="save-key" - That's XUL code from the Ligntning add-on. Disable Lightning.

Thanks, yes, that was Lightning.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED

It would just be interesting to know where that version of Lightning came from since it should also work with Lightning.

Resolution: FIXED → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

Can't say now, I just removed Lightning.
But, I didn't find any Errors in Lightning localization too.
So, we need to check if the problem exists in a new Installation of Thunderbird.

hy-AM locale has a XUL code error (screenshot is attached) from Lightning with a new, clean installation of Thunderbird 68.x.x.

Attached image Untitled.png

Could someone on the the Calendar team have a look what's going on with this localisation.

Flags: needinfo?(ssitter)
Flags: needinfo?(paul)
Flags: needinfo?(geoff)

I cannot read the message on top of the error panel but those messages are the Mozilla way of indicate that localization strings are missing. I don't know how Thunderbird/Lightning localization works in recent years. As far as I known in the past missing localized string were automatically replaced by English (US) strings during packaging (or similar).

Looks like some of the missing strings like 'event.statusbarpanel.privacy.label' were added yesterday (2019-10-19) with https://hg.mozilla.org/l10n-central/hy-AM/rev/1c6e1815d1e0b7909c2deb4d016da3dfa0ea0356

Flags: needinfo?(ssitter)

Reporter: What happens when you install Lightning from ATN: https://addons.thunderbird.net/en-GB/thunderbird/addon/lightning/

(In reply to Jorg K (GMT+2) from comment #12)

Reporter: What happens when you install Lightning from ATN: https://addons.thunderbird.net/en-GB/thunderbird/addon/lightning/

The same error after installing Lightning from ATN: https://addons.thunderbird.net/en-GB/thunderbird/addon/lightning/

At this moment Lightning translated into Armenian in 75%.

I've installed the Armenian version now, but it's really hard to drive :-(

Have you looked in the error console, I see this:

XML վերլուծության սխալմունք՝ չսահմանված բովանդակություն
Տեղը՝ jar:file:///C:/Users/jorgk/AppData/Roaming/Thunderbird/Profiles/auhki3a2.default-release/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D.xpi!/chrome/lightning/content/lightning/lightning-item-panel.xul
Տող համարը՝ 107, սյունը՝ 11. lightning-item-panel.xul:107:11
XML վերլուծության սխալմունք՝ չսահմանված բովանդակություն
Տեղը՝ jar:file:///C:/Users/jorgk/AppData/Roaming/Thunderbird/Profiles/auhki3a2.default-release/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D.xpi!/chrome/lightning/content/lightning/messenger-overlay-sidebar.xul
Տող համարը՝ 289, սյունը՝ 7. messenger-overlay-sidebar.xul:289:7
XML վերլուծության սխալմունք՝ չսահմանված բովանդակություն
Տեղը՝ jar:file:///C:/Users/jorgk/AppData/Roaming/Thunderbird/Profiles/auhki3a2.default-release/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D.xpi!/chrome/calendar/content/calendar/calendar-task-view.xul
Տող համարը՝ 116, սյունը՝ 33. calendar-task-view.xul:116:33

I also tried installing Lightning 68.1.2 from ATN and it made no difference. However, when removing the hy-AM locales from the XPI (using 7Zip), the application became good. So this is a localisation issue.

The bad news is that it's too late to fix this in TB 68.

Flags: needinfo?(paul)

(In reply to Jorg K (GMT+2) from comment #15)

I've installed the Armenian version now, but it's really hard to drive :-(

Have you looked in the error console, I see this:

XML վերլուծության սխալմունք՝ չսահմանված բովանդակություն
Տեղը՝ jar:file:///C:/Users/jorgk/AppData/Roaming/Thunderbird/Profiles/auhki3a2.default-release/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D.xpi!/chrome/lightning/content/lightning/lightning-item-panel.xul
Տող համարը՝ 107, սյունը՝ 11. lightning-item-panel.xul:107:11
XML վերլուծության սխալմունք՝ չսահմանված բովանդակություն
Տեղը՝ jar:file:///C:/Users/jorgk/AppData/Roaming/Thunderbird/Profiles/auhki3a2.default-release/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D.xpi!/chrome/lightning/content/lightning/messenger-overlay-sidebar.xul
Տող համարը՝ 289, սյունը՝ 7. messenger-overlay-sidebar.xul:289:7
XML վերլուծության սխալմունք՝ չսահմանված բովանդակություն
Տեղը՝ jar:file:///C:/Users/jorgk/AppData/Roaming/Thunderbird/Profiles/auhki3a2.default-release/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D.xpi!/chrome/calendar/content/calendar/calendar-task-view.xul
Տող համարը՝ 116, սյունը՝ 33. calendar-task-view.xul:116:33

I also tried installing Lightning 68.1.2 from ATN and it made no difference. However, when removing the hy-AM locales from the XPI (using 7Zip), the application became good. So this is a localisation issue.

The bad news is that it's too late to fix this in TB 68.

So, we need to fix any strings in translation? I didn't see any Errors in Translation Status on Pontoon.

The locale is tied to the broken revision I linked to in comment 13. I don't know enough about the L10n process to know if we can change that.

Meanwhile I've put version 68.2 on ATN with the hy-AM locale disabled, so there's a workaround. (Pending reviewer approval.)

Issue exists in TB 68.3.0

Of course it does since the localisation is "frozen". Even if you fix the localisation error, whatever it may be, those changes won't be included into TB 68.x. How does TB 72 beta 1 look?

As I said, we don't have any localization errors, we just had a missing translations...But, everything is OK now in TB 72 beta 1.

OK, then talk to Francesco to see whether anything can be done to get those missing strings into TB 68.x. I'm sure the TB 68 release manager would be happy to update the l10n pinning if technically possible:

https://hg.mozilla.org/releases/comm=(EDIT)=esr68/rev/1816aaf99a92c9e4f42f459706e678bd4181fb86#l1.333

Flags: needinfo?(francesco.lodolo)

Since we're still tracking ESR68 in the cross-channel repository, you should just be able to pick any updated changeset from l10n-central for the build.

P.S. sorry if I sound like a broken record, but Thunderbird should have someone in charge of l10n, and that person is really not me.

Flags: needinfo?(francesco.lodolo)

Geoff or Rob, can you take care of a better pinning for hy-AM for the next TB 68.x release. TB with Calendar is pretty much unusable in that locale.

Flags: needinfo?(rob)
Flags: needinfo?(geoff)

I talked to Magnus about this the other day... Without signoffs in the localization tool no updates can be made.
[Edit] I read through the history. I think I can make something happen. Will still need approval from SWIM.

Flags: needinfo?(rob) → needinfo?(mkmelin+mozilla)

I think I fixed it?

I don't have funny XUL errors at least...

Attached patch patchSplinter Review
As suggested in comment 22, I manually pinned the hy-AM locale to a newer rev.
I picked the current tip on default, since that's what beta currently points
to and it was mentioned in comment 20 that TB72b1 does not present with the
error.

If anyone else would like to verify, there is a try build at
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=eaa8e4390a317ec12aa21d5884a9a3450b9419d6

You will want target(3) from the Ns6 job on whatever platform. I verified
with Linux64, screenshot in comment 25.
Attachment #9115579 - Flags: review?(mkmelin+mozilla)
Assignee: nobody → rob
Status: REOPENED → ASSIGNED

Moving this to TB so our uplift queries will catch it.

So we're pinning to the current tip:
https://hg.mozilla.org/l10n-central/hy-AM/file/ea57d41779c736c1f5a281dc7bec2ff8c6ba441d

Component: hy-AM / Armenian → General
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)
Product: Mozilla Localizations → Thunderbird
Target Milestone: --- → Thunderbird 68.0
Version: unspecified → 68
Attachment #9115579 - Flags: review?(mkmelin+mozilla)
Attachment #9115579 - Flags: review+
Attachment #9115579 - Flags: approval-comm-esr68+

What's the plan for shipping this? It could have gone out in TB 68.3.1 or is this considered risky?

Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)

Yeah, I think we should take it. It would only ever affect the (currently broken) hy-AM locale.

Flags: needinfo?(mkmelin+mozilla)
Status: ASSIGNED → RESOLVED
Closed: 6 months ago3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.