Remove header dependencies between mozglue/dllservices and browser/app/winlauncher
Categories
(Core :: mozglue, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox69 | --- | unaffected |
firefox70 | --- | unaffected |
firefox71 | --- | fixed |
People
(Reporter: jorgk-bmo, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: regression)
Attachments
(6 obsolete files)
Pretty busted right now, and this
https://hg.mozilla.org/mozilla-central/rev/8e2da9ff5f5aace0988f8d358aafdba04cddf950#l1.12
is just the beginning.
The main issue is:
0:08.66 c:/mozilla-source/comm-central/mozglue/dllservices/LoaderObserver.h(11,10): fatal error: 'mozilla/NtLoaderAPI.h' file not found
0:08.66 #include "mozilla/NtLoaderAPI.h"
Reporter | ||
Comment 1•5 years ago
|
||
And also:
0:09.45 c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/include\mozilla/glue/WindowsDllServices.h(12,10): fatal error: 'mozilla/LoaderAPIInterfaces.h' file not found
0:09.45 #include "mozilla/LoaderAPIInterfaces.h"
Reporter | ||
Comment 2•5 years ago
|
||
Reporter | ||
Comment 3•5 years ago
•
|
||
If I hard-code some some paths, I can get it to compile (so far). So something has gone wrong with some Makefile or build magic :-(
Reporter | ||
Comment 4•5 years ago
|
||
I wonder whether this affects Windows only. I'll push the C-C patch and retrigger the Dailies.
Reporter | ||
Updated•5 years ago
|
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/1eb948124d13 Port bug 1542830: adjustments to mail/app/nsMailApp.cpp. rs=bustage-fix DONTBUILD
Reporter | ||
Comment 6•5 years ago
|
||
Hmm, the M-C patch also doesn't let me compile, after a while I get:
0:13.19 In file included from c:/mozilla-source/comm-central/toolkit/crashreporter/minidump-analyzer/minidump-analyzer.cpp:30:
0:13.19 c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/include\mozilla/glue/WindowsDllServices.h(12,10): fatal error: '../../browser/app/winlauncher/freestanding/LoaderAPIInterfaces.h' file not found
0:13.19 #include "../../browser/app/winlauncher/freestanding/LoaderAPIInterfaces.h"
Strangely the automation run is into 19 minutes and hasn't failed. So is it just me?
Reporter | ||
Comment 7•5 years ago
|
||
Comment on attachment 9094383 [details] [diff] [review] 1582937-C-C.patch Review of attachment 9094383 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/app/nsMailApp.cpp @@ +24,5 @@ > #include "nsIFile.h" > > #ifdef XP_WIN > +# include "LauncherProcessWin.h" > +# include "mozilla/WindowsDllBlocklist.h" BTW, # include "LauncherProcessWin.h" was added to M-C here: https://hg.mozilla.org/mozilla-central/rev/eb5c30217df9#l5.12 Looks like we didn't port it back then, so I've added it now to align with M-C again.
Reporter | ||
Comment 8•5 years ago
|
||
Comment on attachment 9094383 [details] [diff] [review] 1582937-C-C.patch This should be good for review.
Reporter | ||
Comment 9•5 years ago
|
||
OK, a clobber build got me further, but like in automation it fails at the end:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=1eb948124d131b9e064c5ea44750a03a666544c6&selectedJob=267794793
z:/task_1569052759/build/src/obj-thunderbird/dist/include\mozilla/glue/WindowsDllServices.h(12,10): fatal error: 'mozilla/LoaderAPIInterfaces.h' file not found
Comment 10•5 years ago
|
||
Comment on attachment 9094383 [details] [diff] [review] 1582937-C-C.patch Review of attachment 9094383 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/app/nsMailApp.cpp @@ +23,5 @@ > #include "nsCOMPtr.h" > #include "nsIFile.h" > > #ifdef XP_WIN > +# include "LauncherProcessWin.h" Doesn't this need also the other files added by bug 1454745 and the change in moz.build?
Reporter | ||
Comment 11•5 years ago
|
||
Hmm, you mean browser/app/LauncherProcessWin.cpp/h and
+ SOURCES += [
+ 'LauncherProcessWin.cpp',
+ ]
Good question. If we don't port that, I guess adding the include file also doesn't make sense.
But that's just a secondary issue. Right now, we need to fix the bustage. BTW, to get going again locally, I did:
hg qbackout -s -r da7e775c4051fa5803873a409da0ffaf5cb0a864:6fcb417f7ff4048f0237e4949639d305198e20ad
to backout bug 1542830 so I can work again. Sadly, there is more "weekend bustage" I need to take care of.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 12•5 years ago
|
||
Looking at this again, the basic issue is that source code in mozglue/dllservices relies on code in browser/app/winlauncher. That won't work for TB. I tried copying the entire winlauncher directory to mail/app, but had no success compiling it so far.
Reporter | ||
Comment 13•5 years ago
|
||
OK, some tweaks to moz.build + a copy of browser's winlauncher. It doesn't compile.
Reporter | ||
Comment 14•5 years ago
|
||
Comment on attachment 9094383 [details] [diff] [review] 1582937-C-C.patch Yes, I'll remove the include again since we don't have app\winlauncher\LauncherProcessWin.h so far.
Comment 15•5 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/2bd686fea9ae Remove include of app/winlauncher/LauncherProcessWin.h again which Thunderbird doesn't have. r=me
Comment 16•5 years ago
|
||
mach configure completed and the build is progressing.
Reporter | ||
Comment 17•5 years ago
|
||
OK, this should work together with Rob's llvm-dlltool-commmail.patch for M-C.
As the commit message says: Copy browser/app/winlauncher to mail/app/winlauncher.
Reporter | ||
Comment 18•5 years ago
|
||
So, with both patches together, TB compiles and runs. Time to ask for reviews.
Reporter | ||
Comment 19•5 years ago
•
|
||
Comment on attachment 9094410 [details] [diff] [review] llvm-dlltool-commmail.patch Whoever comes first. This is pretty urgent.
Reporter | ||
Comment 20•5 years ago
|
||
Comment on attachment 9094411 [details] [diff] [review] patch-to-copy-winlauncher.patch Straight copy with some build stuff also copied. Can we improve the ``` + LOCAL_INCLUDES += [ + '/comm/mail/app/winlauncher', + ] ``` Oh yes, there are some Firefox strings I should change to Thunderbird.
Assignee | ||
Comment 21•5 years ago
|
||
Comment on attachment 9094410 [details] [diff] [review] llvm-dlltool-commmail.patch Review of attachment 9094410 [details] [diff] [review]: ----------------------------------------------------------------- You shouldn't need any of this stuff for Thunderbird. Let's sort out the parts that you actually need to build instead of pulling in the world.
Assignee | ||
Comment 22•5 years ago
|
||
Comment on attachment 9094411 [details] [diff] [review] patch-to-copy-winlauncher.patch Review of attachment 9094411 [details] [diff] [review]: ----------------------------------------------------------------- You should not need to pull in the world from the launcher process to get Thunderbird to build. Let's isolate the stuff that is actually needed and just take care of that.
Assignee | ||
Comment 23•5 years ago
|
||
Also, in Firefox we build xpcshell.exe
and plugin-container.exe
just fine without linking them against launcher process libs, so there's no reason why we need to do that for thunderbird.exe
. We just need to sort out mozglue
's header dependencies.
Reporter | ||
Comment 24•5 years ago
|
||
I whole-heartedly agree with comment #21 to comment #23. I don't want to fork that stuff and maintain it. I much prefer a "small" solution. Can you give us a hand with "We just need to sort out mozglue's header dependencies"?
Assignee | ||
Comment 25•5 years ago
|
||
Assignee | ||
Comment 26•5 years ago
|
||
Can you try my patch in https://phabricator.services.mozilla.com/D46715 and see if I got everything?
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 28•5 years ago
|
||
Moving to mozglue.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 29•5 years ago
|
||
I'll fold this into the next landing of bug 1542830
Updated•5 years ago
|
Updated•2 years ago
|
Description
•