158299 - Pictures are not blocked

Status: RESOLVED DUPLICATE of bug 176950

(Core :: Graphics: Image Blocking, defect, P3)

Description

[Maciek]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.0.0) Gecko/20020530
BuildID:    2002053012

It looks like I blocked pictures from certain servers. After some time I not
noticed that pictures from the server reappear and but the only option given to
me with popup menu is to UNBLOCK picture. It looks like theoretically server is
blocked, but actually it isn't. Therefore, pictures from this server are showing
up in additional window frames. The weird sumpthom is that problem arises after
some time (or is noticeable after some time). At first blocking works fine.

The example URL is not the only that brings problems.

Reproducible: Didn't try
Steps to Reproduce:
I can't help as I am a liilte busy to investigate Mozzila's problems. However,
the problem arises on regular basis after several days of use of the feature. It
is sort of annoying and and blocking pictures from a particular server seems to
be useless.

Actual Results:  Please, try to reproduce the problem yourself.

Expected Results:  Mozilla should consistently  block loading pictures from
server once blocking feature was used against that particular server.

Comment 1

[Christopher Hoess (gone)]

reassign to image blocking

Comment 2

[Pratik]

I've seen this problem. Here's an example of what happens

1. Say you have doubleclick.com blocked for images
2. You come across a site that serves images from www.doubleclick.net
3. Mozilla displays those images but when you right click it thinks the image is
blocked because it finds doubleclick.com in its list and thinks its blocked.

The problem here is the image blocking code and context menu code seem to be out
of sync.

If you want to see this in action, add doubleclick.com in your list of server to
block images from, then go to www.doubleclick.com. The doubleclick logo in upper
left hand corner is served from www.doubleclick.com and is displayed (correctly)
but right clicking it says "Unblock image", which is wrong.

I have a strong feeling this bug is probably filed and should be marked dup. I
went through the list of bugs but I can't figure out which bug to mark dupe.
Thus, marking this bug as new.

Comment 3

[Maciek]

I do not know why my description was modified. I said precisely that it relates
to any web site popping up windows (not just doubleclick.com). The pictures are
blocked but after some time and with some circumstances they seem to be not
blocked becuase they appear in poped window and the only option on popup menu is
to UNBLOCK them for unknown reason.

It seems that Mozilla does not block loading pictures servers consistently.
That's as simple and does not relate to any particular web site.

Please, besides blocking picture loaded regular way you need to block JavaScript
loaded pictures. It would be also good if you could block Flash content from
some servers.

Comment 4

[Pratik]

>I do not know why my description was modified. 

I merely tried to give a more concrete example based on what I thought the bug
was about.

>I said precisely 

No you were not precise. You can't say it happens on any website. Give an
example. State what prefs have to be enabled/disabled to see this bug. I have
pops disabled. Would I see this bug in such situation?

>that it 
>relates to any web site popping up windows (not just doubleclick.com). 
>The pictures are blocked but after some time and with some circumstances 
>they seem to be not blocked becuase they appear in poped window and the 
>only option on popup menu is to UNBLOCK them for unknown reason.

You need to be more specific. If what I described isn't what you're referring
to, then please be more specific.

>It seems that Mozilla does not block loading pictures servers 
>consistently. That's as simple and does not relate to any particular web site.

Yes but if you give an example of one website then we can confirm that this bug
exists and its not the website's fault.

>Please, besides blocking picture loaded regular way you need to 
>block JavaScript loaded pictures. It would be also good if you could 
>block Flash content from some servers.

There's a bug filed about flash content.

Comment 5

[Stephen P. Morse]

I don't understand steps to reproduce problem, as given in comment 2:

1. add doubleclick.com in your list of server to block images from,

How?  I can do that going to doubleclick.com which of course takes me to 
www.doubleclick.com.  Then I rightclick an image and say block.  That adds 
www.doubleclick.com to the blocked list as shown by the image manager.

2. go to www.doubleclick.com.

Well I was there already, so I did a reload.

3. The doubleclick logo in upper left hand corner is served from 
www.doubleclick.com and is displayed (correctly)

No, I don't have any images displayed.

--------------

Please clarify the steps so that I can reproduce.  Thanks.

Comment 6

[Maciek]

Please try several times more over a few days using Mozilla 1.0 and you will 
notice the problem.


I ensure you Mozilla does not block loading pictures from server consistently
for some reason.

Now why by rihgt clicking on a picture already loaded and getting popup menu
would I have UNBLOCK menu option instead BLOCK option? I may even try and
capture screen to make you believe.

That's how build 2002053012 behaves and please do not count on the fact that
just after blocking and reloding web page you will notice the problem. It does
not need to appear right away and on the same picture. It appears after some use
for some reason. Perhaps in some cases pictures are loaded differently or any
other circumstances are different than just after blocking.

Comment 7

[Stephen P. Morse]

So you are saying that the problem is not reproducible.  In that case I don't 
know how I'm going to be able to debug it.

Comment 8

[Pratik]

Okay. I think I might have been hasty and given steps to reproduce a problem
that may not be what the reporter intended to report. 

In any case, to reproduce the problem that I see

1. goto http://doubleclick.com/us/ 
2. Block images from that website
3. Now go to www.doubleclick.com.
4. The image gets displayed, but right clicking says "Unblock Image"

I'll file a new bug if this is not what the reporter intended.

Comment 9

[Stephen P. Morse]

Thanks for the clarification.  And now I am able to reproduce and to see the 
problem.  The fact that the image is displayed is correct behavior (site being 
blocked and current site are indeed different), but message in context menu is 
incorrect.  You are right in saying that the two are out of synch.

I suspect that this is what the reporter was observing as well although he 
didn't realize it.  On certain days he might have been visiting the site with 
www.xxx.com and on other days as simply xxx.com.  So it's easy to mistakenly 
conclude that the behavior changed over time rather than because the site being 
visited was different.

Accepting the bug

Comment 10

[Quinn Yost (mythdraug)]

I believe this is a dupe of bug 48660.   

Comment 11

[Mitchell Stoltz (not reading bugmail)]

Reassigning Image Manager bugs to mstoltz and clearing milestone.

Comment 12

[Mitchell Stoltz (not reading bugmail)]

This bug was accidentally marked security-sensitive yesterday. Removing
security-sensitive status now.

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

This is fixed (somewhat) with the checkin in bug 176950. If not, please reopen

*** This bug has been marked as a duplicate of 176950 ***