1583025 - Address bar pushes Hamburger button out of browser after expanding the browser width if whats-new-menu-button is displayed.

Status: RESOLVED DUPLICATE of bug 1595514

(Firefox :: Messaging System, defect, P1)

Description

[Alice0775 White]

Reproducible: yes

Steps To Reproduce:

1. Make sure whats-new-menu-button is displayed
2. Resize browser width

Actual Results:
Hamburger button sometimes out of browser. No longer able to access the button without further resize width.
Screencast : https://youtu.be/n2S7rSIPuyI

Expected Results:
Hamburger button should be always visible

Comment 1

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
User-visible regressions in toolbar usability.

Ricky, can you take a look please?

Also, in future, please ensure browser peers review your changes to browser.xhtml and related files. There are... a number of mistakes in the changes in https://hg.mozilla.org/mozilla-central/rev/975200b42f28 that maybe peer review would have caught...

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Passing it on to :andreio.

Comment 3

[Andrei Oprea [:andreio]]

Attachment: Bug 1583025 - Address bar pushes Hamburger button out of view when What's New button is displayed

Comment 4

[Liz Henry (:lizzard)]

Too late for a fix in 70 but we could still take a patch for 71/72.

Comment 5

[Andrei Oprea [:andreio]]

I'm having trouble reproducing this. I do see a small flicker while expanding as toolbar buttons come out of the overflow menu into the toolbar but I was never able to hit a broken state. Is this still happening?

Comment 6

[Alice0775 White]

Build ID 20191008093420
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

I can still reproduce.

Comment 7

[Julien Cristau [:jcristau]]

Andrei what's the status of this bug/patch?

Comment 8

[Andrei Oprea [:andreio]]

I haven't been able to get this to reproduce consistently so I don't have a good fix. It will get pushed to 72.

Comment 10

[Pascal Chevrel (relman team) -> :pascalc]

Andrei, there are steps to reproduce in the duplicate bug 1593261, could you try them please? Thanks

Comment 11

[Andrei Oprea [:andreio]]

Reproduces on lower resolution device. It looks like the issue is not specific to the what's new button. I created a separate bug.

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

We have shipped our last beta for 71, since this is a P1, I am keeping the status as fix-optional for 71 in case a safe uplift is possible in a future dot-release.

Comment 13

[Liz Henry (:lizzard)]

72 ships early in January - we could still potentially take a patch for 73 though.

Comment 14

[Marcia Knous [:marcia]]

(In reply to Andrei Oprea [:andreio] from comment #11)

Reproduces on lower resolution device. It looks like the issue is not specific to the what's new button. I created a separate bug.

Should we keep this bug open or track in Bug 1595514?

Comment 15

[Andrei Oprea [:andreio]]

Let's track it in bug 1595514 and I can reopen this if it's still a problem afterwards.