async-scrollbar-* tests are not drawing the scrollbars on mac + WR
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
People
(Reporter: gw, Unassigned)
References
Details
(Keywords: regression)
They started to fail intermittently with the snapping changes (see https://bugzilla.mozilla.org/show_bug.cgi?id=1581878).
This refactoring patch https://phabricator.services.mozilla.com/D46125 has made them permanently PASS, but that's because the scrollbars don't draw at all so the images are equal.
I confirmed that they still fail to draw, even with picture caching completely disabled, which rules out any changes in the refactoring patch above. I also rebased my patch prior to the snapping changes, and the scrollbars were drawing correctly.
|
||
Comment 1•5 years ago
|
||
Maybe bug 1581934 fixes this.
|
||
Comment 2•5 years ago
|
||
So, just to make sure I'm understanding this:
- with neither bug 1574493 nor bug 1581757: the tests consistently pass and render the scrollbar
- with bug 1574493 but not bug 1581757: the tests intermittently fail because they sometimes don't render the scrollbar
- with both bug 1574493 and bug 1581757: the tests consistently pass because they never render the scrollbar
- with bug 1581757 but not bug 1574493: the tests consistently pass and render the scrollbar
Did I get that right?
|
Reporter | |
Comment 3•5 years ago
|
||
I worked out what's going on - the changes I'm making in https://phabricator.services.mozilla.com/D46125 expose a pre-existing bug in WR related to the clipping stack. So it's unrelated to the snapping changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1581878, they just tripped me up in working out what is going on, since they affect the same set of tests.
Description
•