Closed Bug 1583154 Opened 5 years ago Closed 5 years ago

4.95% build times (windows2012-64) regression on push 1286d4b97efd3623db92b28472707c6fc4496d55 (Tue September 10 2019)

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox71 affected)

RESOLVED WONTFIX
mozilla71
Tracking Status
firefox71 --- affected

People

(Reporter: marauder, Unassigned)

References

(Regression)

Details

(Keywords: perf-alert, regression)

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=1286d4b97efd3623db92b28472707c6fc4496d55

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

5% build times windows2012-64 debug plain taskcluster-c4.4xlarge 2,311.34 -> 2,425.70

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=23190

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Blocks: 1578356
Component: Performance → General
Flags: needinfo?(mh+mozilla)
Product: Testing → Firefox Build System
Regressed by: 1579156
Target Milestone: --- → mozilla71
Version: Version 3 → unspecified

The numbers in the alert make it look much worse when it actually is: looking at the build on the landing of bug 1579156, its value is 2337, not 2425. And the push before had 2283, which, if you look at older things, was actually particularly on the low end. Even using that the alert as shown by the graph is 2.4%. But if you account for the fact that most values were already above 2300, and that the overall decrease is almost invisible in the graph, I'm going to call this WONTFIX.

Although, for the record, there is a difference between before bug 1573566 and after bug 1579156: the binding tests are compiled later, and that may be the cause for this small regression.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(mh+mozilla)
Resolution: --- → WONTFIX

Thanks for the details, Mike.

Blocks: 1592626
No longer blocks: 1592626
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.