1583155 - compare hyperlink from Graphs view popup is broken

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Ionuț Goldan [:igoldan]]

Attachment: compare-hyperlink-broken.swf

Seems like there's a problem with old compare hyperlink that shows up between parenthesis, inside the dark popup from Graphs view.
It lands the user to a Compare view page, which always seem to state that it has "No results to show", even though there are results.

I've uploaded a video reproducing this issue. The Graphs view URL I've started with is https://treeherder.mozilla.org/perf.html#/graphs?timerange=31536000&series=autoland,2008413,1,10&highlightedRevisions=918d7c84da371&highlightAlerts=0&zoom=1561380071782,1561667216671,220.08590900341508,464.541100511623&selected=2008413,501958,859.2130188812101,185.99942921444247

In reproducing this, I made sure that the test ran successfully on both the base & the new push.

Comment 1

[Sarah Clements [:sclements]]

This doesn't seem to be an issue with the link. I manually typed in those revisions and projects for raptor tests with the compare chooser, and if you type 'instagram' into the search box you only see results for three tests - one being a similar test: "raptor-tp6m-instagram-geckoview-cold pgo" but with signature #2008411. The link you shared has a signature of #2008413 with the name "raptor-tp6m-instagram-geckoview-cold fcp pgo".

https://treeherder.mozilla.org/perf.html#/compare?originalProject=autoland&originalRevision=f15dfe18a9d909416c798954c9af254b3a1155b3&newProject=autoland&newRevision=918d7c84da371bda26460fb4b50f161d32107880&framework=10

Edit: I looked closer at the link and I'm remembering now that this was an issue from before the conversion that I had discovered - whether to use a parent signature or signature for looking at subtests from the graph view. I've created a patch so now the graph link will pull results from the parent signature which is actually 2008411 (in this case). I'll include this patch in the prod push today.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5396