Closed Bug 1583174 Opened 5 years ago Closed 5 years ago

No breakable line available in actors/thread.js from BrowserContentToolbox

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: jdescottes, Assigned: bhackett1024)

Details

Attachments

(1 file)

Clean profile.

STRs:

  • open DevTools
  • open BrowserContentToolbox (BCT)
  • select Debugger in BCT
  • open server/actors/thread.js

All lines are greyed out.
In the stdout, you can find the following:

console.error: "Error while calling actor 'source's method 'getBreakableLines'" "function is optimized out"
console.error: "getBreakpointPositions@resource://devtools/server/actors/source.js:425:1\nasync*getBreakableLines@resource://devtools/server/actors/source.js:267:34\nhandler@resource://devtools/shared/protocol/Actor.js:154:37\nonPacket@resource://devtools/server/debugger-server-connection.js:378:58\nreceiveMessage@resource://devtools/shared/transport/child-transport.js:66:16\nMessageListener.receiveMessage*_addListener@resource://devtools/shared/transport/child-transport.js:40:14\nready@resource://devtools/shared/transport/child-transport.js:57:10\n_onConnection@resource://devtools/server/debugger-server.js:450:15\nconnectToParent@resource://devtools/server/debugger-server.js:331:17\ninit@resource://devtools/server/startup/content-process.jsm:69:31\nonInit@resource://devtools/server/startup/content-process.js:25:9\nMessageListener.receiveMessage*@resource://devtools/server/startup/content-process.js:34:19\n"
console.warn: "Action loadSourceActorBreakableLines had an exception:" "Protocol error (unknownError): function is optimized out"
console.warn: "Action loadSourceText had an exception:" "Protocol error (unknownError): function is optimized out"

It seems really specific to this file, I tried a dozen other server files, they all had breakable lines

Brian, could this be from the new reparsing logic? Maybe we're accessing Script that would have otherwise been inaccessible?

Flags: needinfo?(bhackett1024)

(In reply to Logan Smyth [:loganfsmyth] from comment #1)

Brian, could this be from the new reparsing logic? Maybe we're accessing Script that would have otherwise been inaccessible?

Yeah, it does seem that way. I'm not sure what circumstances spidermonkey will entirely optimize out a function, but in any case we should tolerate exceptions being thrown while getting a script's breakpoint positions, so that it doesn't interfere with getting positions for other scripts in the source.

Flags: needinfo?(bhackett1024)
Assignee: nobody → bhackett1024
Status: NEW → ASSIGNED
Has STR: --- → yes
Priority: -- → P2
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6601ef3019e2
Watch for exceptions being thrown while getting a script's breakpoint positions, r=jlast.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: