1583225 - Import WebCompat GoFaster 6.1.0 sources

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, task, P1)

Description

[Mike Taylor [:miketaylr]]

Please use the version 6.1.0 (since we're shipping 6.0.3 via Balrog to release right now) and request beta uplift once it lands in tree.

Comment 1

[Rob Wu [:robwu]]

In the future, should I submit patches to m-c, or to the Github repo?

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1583225 - Import WebCompat GoFaster 6.1.0 sources; r?miketaylr

Import WebCompat GoFaster 6.1.0 sources

Comment 3

[Mike Taylor [:miketaylr]]

(In reply to Rob Wu [:robwu] from comment #1)

In the future, should I submit patches to m-c, or to the Github repo?

GitHub is our preferred workflow, thanks!

(we slightly hacked things for Bug 1564594, happy to explain why on slack)

Comment 4

[Thomas Wisniewski [:twisniewski]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0062af160c5eb3b2e0ed2040c82d0ec7c0228986

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07c68c882f14
Import WebCompat GoFaster 6.1.0 sources; r=miketaylr

Comment 6

[Mike Taylor [:miketaylr]]

Please request beta uplift once this lands.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

And Release & ESR68.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/07c68c882f14

Comment 9

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 9094644 [details]
Bug 1583225 - Import WebCompat GoFaster 6.1.0 sources; r?miketaylr

Beta/Release Uplift Approval Request

• User impact if declined: Users may experience a menu regression with GMail as per bug 1581967, as well as a number of other webcompat issues.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk. The fix is limited to the webcompat system addon, and the same fix is already being deployed via Balrog without any reported issues so far.
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This patch fixes a web compat regression in GMail along with other site fixes and a bug fix for the pending Fennec ESR Enhanced Search experiment.
• User impact if declined: Users may experience a menu regression with GMail as per bug 1581967, as well as a number of other webcompat issues.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk. The fix is limited to the webcompat system addon, and the same fix is already being deployed via Balrog without any reported issues so far.
• String or UUID changes made by this patch:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9094644 [details]
Bug 1583225 - Import WebCompat GoFaster 6.1.0 sources; r?miketaylr

Updates the in-tree copy of the webcompat addon to what we're already serving to users over Balrog anyway. Approved for 70.0b11.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8d4dfb36052d

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9094644 [details]
Bug 1583225 - Import WebCompat GoFaster 6.1.0 sources; r?miketaylr

Also approved for Release (in the event of another 69.x dot release) and ESR68 for 68.2esr/Fennec 68.2b5.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/8bba3b8515e0

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/455681ce4c84