Closed Bug 1583225 Opened 3 months ago Closed 3 months ago

Import WebCompat GoFaster 6.1.0 sources

Categories

(Web Compatibility :: Interventions, task, P1)

Tracking

(firefox-esr68 fixed, firefox69 fixed, firefox70 fixed, firefox71 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr68 --- fixed
firefox69 --- fixed
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: miketaylr, Assigned: twisniewski)

References

Details

Attachments

(1 file)

Please use the version 6.1.0 (since we're shipping 6.0.3 via Balrog to release right now) and request beta uplift once it lands in tree.

In the future, should I submit patches to m-c, or to the Github repo?

Blocks: 1581967

Import WebCompat GoFaster 6.1.0 sources

(In reply to Rob Wu [:robwu] from comment #1)

In the future, should I submit patches to m-c, or to the Github repo?

GitHub is our preferred workflow, thanks!

(we slightly hacked things for Bug 1564594, happy to explain why on slack)

See Also: → 1583285
See Also: → 1564594
Pushed by twisniewski@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07c68c882f14
Import WebCompat GoFaster 6.1.0 sources; r=miketaylr

Please request beta uplift once this lands.

Flags: needinfo?(twisniewski)

And Release & ESR68.

Comment on attachment 9094644 [details]
Bug 1583225 - Import WebCompat GoFaster 6.1.0 sources; r?miketaylr

Beta/Release Uplift Approval Request

  • User impact if declined: Users may experience a menu regression with GMail as per bug 1581967, as well as a number of other webcompat issues.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Low risk. The fix is limited to the webcompat system addon, and the same fix is already being deployed via Balrog without any reported issues so far.
  • String changes made/needed:

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: This patch fixes a web compat regression in GMail along with other site fixes and a bug fix for the pending Fennec ESR Enhanced Search experiment.
  • User impact if declined: Users may experience a menu regression with GMail as per bug 1581967, as well as a number of other webcompat issues.
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Low risk. The fix is limited to the webcompat system addon, and the same fix is already being deployed via Balrog without any reported issues so far.
  • String or UUID changes made by this patch:
Flags: needinfo?(twisniewski)
Attachment #9094644 - Flags: approval-mozilla-esr68?
Attachment #9094644 - Flags: approval-mozilla-beta?

Comment on attachment 9094644 [details]
Bug 1583225 - Import WebCompat GoFaster 6.1.0 sources; r?miketaylr

Updates the in-tree copy of the webcompat addon to what we're already serving to users over Balrog anyway. Approved for 70.0b11.

Attachment #9094644 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9094644 [details]
Bug 1583225 - Import WebCompat GoFaster 6.1.0 sources; r?miketaylr

Also approved for Release (in the event of another 69.x dot release) and ESR68 for 68.2esr/Fennec 68.2b5.

Attachment #9094644 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+
Regressions: 1585903
You need to log in before you can comment on or make changes to this bug.