1583231 - Fix indentation, tooltip use, and CSS of what's new panel and toolbarbutton

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[:Gijs (he/him)]

Bug 1561345 did a few things that aren't quite right.

• The indentation of the toolbar items added doesn't match those of the surrounding nodes
• It set tooltip="bhTooltip", which AFAICT doesn't do anything. I expect attributes that the bookmark/history tooltip (which is what that is) expects aren't present. We should either remove the tooltip attribute or fix the content of the list so that the tooltip works correctly.
• It reinvents the subview header - it should rely on the builtin one if possible.
• The use of consumeanchor="PanelUI-button" is probably wrong, as not all of PanelUI-button will cause the what's new popup to show up.
• the min-width on the panel seems superfluous.
• the height should probably not be in px to cater for different font sizes
• the negative margin used for the standalone panel shouldn't be necessary, but if that is really the case, it should use the mainview selector instead of having 2 selectors, one to add the margin and one to override (all!) the margins back to 0.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1583231 - Fix indentation, tooltip use, and CSS of what's new panel and toolbarbutton

Comment 2

[Andrei Oprea [:andreio]]

Comment on attachment 9094877 [details]
Bug 1583231 - Fix indentation, tooltip use, and CSS of what's new panel and toolbarbutton

Does this look ok?

Comment 3

[:Gijs (he/him)]

Comment on attachment 9094877 [details]
Bug 1583231 - Fix indentation, tooltip use, and CSS of what's new panel and toolbarbutton

(In reply to Andrei Oprea [:andreio] from comment #2)

Comment on attachment 9094877 [details]
Bug 1583231 - Fix indentation, tooltip use, and CSS of what's new panel and toolbarbutton

Does this look ok?

Looks like the right idea; I've added an inline comment because I don't really understand what happened to the content container - is it meant to be added at runtime somewhere?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fe7905b6de9
Fix indentation, tooltip use, and CSS of what's new panel and toolbarbutton r=Gijs

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9fe7905b6de9

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (72.0a1 Build ID - 20191128094109) and latest Firefox Beta (71.0 Build ID - 20191125204040) installed on Windows 10 x64, Mac 10.15.1, and Arch Linux 3.34.1, using the "Developer Tools" and I can confirm the following:

• The consumeanchor="PanelUI-button" string has been removed;
• The "subview" header was set to <toolbaritem id="PanelUI-whatsNew-content" orient="vertical" smoothscroll="false">";
• The panelview[mainview] #PanelUI-whatsNew-content { height was set to 43em;
• The #PanelUI-whatsNew padding-top was set to 0.