1583267 - The website's favicon from the login item changes to the default one if the saved login is edited

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The patch in bug 1577513 was rebased incorrectly prior to landing. The change was made to loginAdded instead of loginModified.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1583267 - Restore the cached website favicon when the login is updated. r?MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7495f0c10ce
Restore the cached website favicon when the login is updated. r=MattN

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f7495f0c10ce

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 71.0a1 (Build ID: 20190924215237) on Windows 7 x64, Mac 10.14 and Arch 14.14 x64.

• The website's favicon is correctly displayed if the saved login is edited.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta uplift request?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9094630 [details]
Bug 1583267 - Restore the cached website favicon when the login is updated. r?MattN

Beta/Release Uplift Approval Request

• User impact if declined: the favicon will disappear from a login until the about:logins page is refreshed when it is edited
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch has been on Nightly for over two weeks.
• String changes made/needed: none

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9094630 [details]
Bug 1583267 - Restore the cached website favicon when the login is updated. r?MattN

Fix for Skyline issue, let's uplift for beta 14.

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6d2ff5bac5f7

Comment 9

[Maria Heres, inactive, contact Ecosystem QA]

I have verified this issue on the Firefox Beta 70.0b14 (Build ID: 20191010142853) on Windows 10 x64, Mac 10.15, Ubuntu 16 x64.

• The website's favicon is now correctly displayed after editing and saving the login details.