1583316 - Fix CSS broken by un-blockification of display: -moz-box (bug 1580012)

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

Bug 1580012 will turn off the blockification of display: -moz-box; with the pref layout.css.xul-box-display-values.survive-blockification.enabled.

We need some changes to fix it. Also one to not crash on startup.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1583316-fix-un-blockification-display-moz-box.patch

Added on position: absolute/fixed a display: block; when nothing was set (also not through xul.css).

I needed also a change for the gloda-autocomplete because some items where centred instead left aligned.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9094700 [details] [diff] [review]
1583316-fix-un-blockification-display-moz-box.patch

Review of attachment 9094700 [details] [diff] [review]:
-----------------------------------------------------------------

Thx Richard, r=mkmelin

::: mailnews/db/gloda/content/glodacomplete.css
@@ +44,5 @@
>    font-style: italic;
>    margin-inline-start: 1em;
>  }
>  
> +.autocomplete-richlistitem[type^="gloda"] {

maybe still add a text comment which types you're matching, so that it's easier to find in code (and understand)

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1583316-fix-un-blockification-display-moz-box.patch

I hope this comment is okay.

Comment 4

[Magnus Melin [:mkmelin]]

Perfect.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8b63311aafa9
Fix CSS broken by un-blockification of display: -moz-box in bug 1580012. r=mkmelin

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1583316-fup-moz-box-to-block.patch

I missed one change from from display: -moz-box; to display: block;. Without this TB will crash when bug 1582530 will land (in autoland actually) and a theme is active.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9096503 [details] [diff] [review]
1583316-fup-moz-box-to-block.patch

What the heck, I can review one line.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/88a00eab31d4
Follow-up: Fix missed change from display: -moz-box; to display: block; r=jorgk

Comment 9

[Richard Marti (:Paenglab)]

Attachment: 1583316-fup-AB-composer-blockification-fix.patch

Damn, I missed another needed change to not crash.

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 9096986 [details] [diff] [review]
1583316-fup-AB-composer-blockification-fix.patch

No problem ;-)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d3ce6d47bde3
Follow-up: Fix missed change from display: -moz-box; to display: block; - take 2. r=jorgk