Closed Bug 1583316 Opened 5 months ago Closed 5 months ago

Fix CSS broken by un-blockification of display: -moz-box (bug 1580012)

Categories

(Thunderbird :: Theme, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(3 files, 1 obsolete file)

Bug 1580012 will turn off the blockification of display: -moz-box; with the pref layout.css.xul-box-display-values.survive-blockification.enabled.

We need some changes to fix it. Also one to not crash on startup.

Added on position: absolute/fixed a display: block; when nothing was set (also not through xul.css).

I needed also a change for the gloda-autocomplete because some items where centred instead left aligned.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9094700 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9094700 [details] [diff] [review]
1583316-fix-un-blockification-display-moz-box.patch

Review of attachment 9094700 [details] [diff] [review]:
-----------------------------------------------------------------

Thx Richard, r=mkmelin

::: mailnews/db/gloda/content/glodacomplete.css
@@ +44,5 @@
>    font-style: italic;
>    margin-inline-start: 1em;
>  }
>  
> +.autocomplete-richlistitem[type^="gloda"] {

maybe still add a text comment which types you're matching, so that it's easier to find in code (and understand)
Attachment #9094700 - Flags: review?(mkmelin+mozilla) → review+

I hope this comment is okay.

Attachment #9094700 - Attachment is obsolete: true
Attachment #9094720 - Flags: review+
Keywords: checkin-needed

Perfect.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8b63311aafa9
Fix CSS broken by un-blockification of display: -moz-box in bug 1580012. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0

I missed one change from from display: -moz-box; to display: block;. Without this TB will crash when bug 1582530 will land (in autoland actually) and a theme is active.

Attachment #9096503 - Flags: review?(mkmelin+mozilla)
Flags: needinfo?(jorgk)
Comment on attachment 9096503 [details] [diff] [review]
1583316-fup-moz-box-to-block.patch

What the heck, I can review one line.
Flags: needinfo?(jorgk)
Attachment #9096503 - Flags: review?(mkmelin+mozilla) → review+
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/88a00eab31d4
Follow-up: Fix missed change from display: -moz-box; to display: block; r=jorgk

Status: REOPENED → RESOLVED
Closed: 5 months ago5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Damn, I missed another needed change to not crash.

Attachment #9096986 - Flags: review?(jorgk)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 9096986 [details] [diff] [review]
1583316-fup-AB-composer-blockification-fix.patch

No problem ;-)
Attachment #9096986 - Flags: review?(jorgk) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d3ce6d47bde3
Follow-up: Fix missed change from display: -moz-box; to display: block; - take 2. r=jorgk

Status: REOPENED → RESOLVED
Closed: 5 months ago5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.